Re: RFC: exclude partitions from efi_selftest

[AKASHI Takahiro <takahiro.akashi@linaro.org>]

On Wed, Sep 15, 2021 at 02:00:31PM +0200, Mark Kettenis wrote:
> > Date: Wed, 15 Sep 2021 12:42:16 +0200
> > From: Heinrich  Schuchardt <xypron.glpk@gmx.de>
> > 
> > Am 15. September 2021 11:56:07 MESZ schrieb Michael Lawnick <ml.lawnick@gmx.de>:
> > >Am 14.09.2021 um 17:57 schrieb Heinrich Schuchardt:
> > >> On 9/14/21 4:56 PM, Michael Lawnick wrote:
> > >>> Hi,
> > >>>
> > >>> in our environment we get error on efi_selftest if one of several SSD
> > >>> partitions isn't properly initialized (due to some other error, but
> > >>> that's a different topic). I tried to track down to where the partitions
> > >>> get registered for test but got a bit lost so I request advice from you.
> > >>
> > >> When the UEFI sub-system is intialized we call efi_disk_register(). If
> > >> it fails, we don't enter the UEFI sub-system.
> > >>
> > >> Are you able to identify where efi_disk_register() fails?
> > >
> > >The system starts up properly.
> > >This is what I see:
> > >ASIM-CN10KAS> efiload $loadaddr
> > >Loaded EFI App image at 0x40080000 with 0x216000 bytes
> > >ASIM-CN10KAS> bootefi $loadaddr $fdtaddr
> > >Scanning disk sdhci@824000000000.blk...
> > >** Unrecognized filesystem type **
> > >** Unrecognized filesystem type **
> > >** Unrecognized filesystem type **
> > 
> > This is not an error. Just an info.
> 
> It is somewhat annoying though.  The way disks are partitioned on the
> Apple M1 systems, there are several Apple native partition types that
> need to be retained and that U-Boot doesn't support.  So you see a lot
> of these warnings.
> 
> Or maybe we should have a whitelist of partition types not to warn
> about?

This message is not UEFI specific, but generic filesystem code
generates it. So you could
1) At fs_probe_unsupported() in fs/fs.c,
   change log_err() to log_warning() [or log_info()]
2) Set CONFIG_DEFAULT_LOG_LEVEL to 3(error) [or 4(warning)]
to suppress the message.

Or you may simply want to modify _log() so as to add a preamble,
like "WARN:", in front of the message.

-Takahiro Akashi