Re: RFC: exclude partitions from efi_selftest

[AKASHI Takahiro <takahiro.akashi@linaro.org>]

On Thu, Sep 16, 2021 at 11:14:01AM +0200, Michael Lawnick wrote:
> Am 16.09.2021 um 10:02 schrieb AKASHI Takahiro:
> > On Thu, Sep 16, 2021 at 09:48:07AM +0200, Michael Lawnick wrote:
> > > Am 16.09.2021 um 09:15 schrieb Michael Lawnick:
> > > > Am 16.09.2021 um 09:12 schrieb AKASHI Takahiro:
> > > > > Please, as Heinrich suggested, add CONFIG_FS_FAT, in your U-Boot configuration.
> > > > > 
> > > > Hmm, I didn't understand that as a suggestion, but as a question for his
> > > > understanding. Of course I'll give it a try.
> > > > 
> > > Sometimes live is such easy. This fixed my issue, THX.
> > > 
> > > For the after-math / my understanding:
> > > - Do I understand correctly that the problem was that 'efi_selftest
> > > block device' requires FAT support? So shouldn't there be a dependency
> > > in CONFIG?
> > 
> > Strictly speaking, CONFIG_EFI_LOADER requires FAT per UEFI specification,
> > and actually it has 'imply FAT'. I don't know why Heinrich uses 'imply'
> > instead of 'select'.
> > 
> > > - What is the reason/use to iterate through the recognized partitions
> > > even twice (in .setup and .execute) if they aren't needed/used?
> > 
> > What line of code do you exactly mean by 'in .setup' (and in .execute)?
> 
> My understanding:
> efi_selftests register their methods separated by setup/execute/teardown.
> The central test control is taking tests from list and executes the
> three methods, unaware of which exact test is executed:
> lib/efi_selftest/efi_selftest.c

That is exactly what efi_selftest.c does.

> lib/efi_selftest/efi_selftest_block_device.c

And this is a test instance for block device test.
So what's your question?

-Takahiro Akashi