From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA3D3C433F5 for ; Thu, 16 Sep 2021 09:37:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 484B360F4A for ; Thu, 16 Sep 2021 09:37:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 484B360F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 61A2F82F33; Thu, 16 Sep 2021 11:37:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Zi81gzKH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E43C82E03; Thu, 16 Sep 2021 11:37:19 +0200 (CEST) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1C5B782E03 for ; Thu, 16 Sep 2021 11:37:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x631.google.com with SMTP id v1so3412473plo.10 for ; Thu, 16 Sep 2021 02:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=QpvOIqHCCrCDeF2FlimIXtBjMxSAj8c2lgsZhHVY01I=; b=Zi81gzKHE7q3ZVRyYmXmpYugeqBBrjksNLm3q3fE2+SNVvdbDldkusaldkl6onjQDX bZu0cjwLM953r4zmdBkDXkzlTZISqPgD/EfGc4bbQQXVSWqzNwCPX8oi/Vk65EvIdoFm +5qD19laMi6J98onZQuiodS0T2+8dQW7XVploqtFLkWygAIn95nwDECdiQbwO0HMF3x3 3U5c5+q+5Cu6dRme5TnngFrDbXoo+7Mf/FODP25RxHmuHWECp5Ejf/3fHQ0fp3c3Ei1N CnWIoyyhgNd+kBEDM1C/EXz9vNsIfJCW8hfCm8SSoWZR49LEuqtdU+FHf0kEbchqU2Q9 J4Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=QpvOIqHCCrCDeF2FlimIXtBjMxSAj8c2lgsZhHVY01I=; b=HJzSc2knUSlpl05rQAV1KKQcQZmumiB0ADAMGD3r4snFZWxKyhKS9GXdbphCsCPGAY 3wH1ZsceJPNoZ65grgPqqTSvwcIBixNioPMEdlksIv+DdQWwV3u7m+EfFGqYiVLusD0j F9FDojbJ7inPPfbMzuSFXXgZQAHYZNYpyCe8UAaq6HZ5j93k6YCWbyuV+bVXyVU66LYi VlGl3NKXjx6/b1tdLeCPQMmT6LYbI2H6aMylLWaJU/bU/KhJmrOAFEyn3QDKkwreU0pZ e2ZICpGn/lOm9/Zy6WGK/qAdXc6bY5QFj3HhVGzTVDX71r/OJW6EGB+zCOn9vICi7wLY MYzA== X-Gm-Message-State: AOAM5331bJnmSAfXN79CHVBVPWWfjgYp+VPZu8c+jH4Z9TvGP59vONnJ X6/gc7j2NmpjCkns20ukf9AGjA== X-Google-Smtp-Source: ABdhPJz7CJTTGTq/tZ2aPNnuD0GvqTXZONOjgBpZPgs0RprCohYVgS/zVlV7MO19QAxabn7TmO0ZWw== X-Received: by 2002:a17:902:b694:b0:138:a031:610d with SMTP id c20-20020a170902b69400b00138a031610dmr4060464pls.36.1631785034184; Thu, 16 Sep 2021 02:37:14 -0700 (PDT) Received: from laputa (p6e421539.tkyea130.ap.so-net.ne.jp. [110.66.21.57]) by smtp.gmail.com with ESMTPSA id g18sm2518110pge.33.2021.09.16.02.37.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 02:37:13 -0700 (PDT) Date: Thu, 16 Sep 2021 18:37:10 +0900 From: AKASHI Takahiro To: Michael Lawnick Cc: u-boot@lists.denx.de Subject: Re: RFC: exclude partitions from efi_selftest Message-ID: <20210916093710.GA79717@laputa> Mail-Followup-To: AKASHI Takahiro , Michael Lawnick , u-boot@lists.denx.de References: <3f6af126-2373-2a8c-5d55-7309bdec0bf6@gmx.de> <139AD9F4-1D9D-46A6-944D-CDAE82F8D56A@gmx.de> <08bac57f-e970-1ddf-3e3d-1f9c0415e74d@gmx.de> <76c02922-0be9-d80d-d853-aeefe3ea124c@gmx.de> <20210916071223.GB59501@laputa> <20db317b-a368-3dc0-8233-c702264e9ccf@gmx.de> <97df9fca-9d6c-1364-cfd8-ee9c417db96e@gmx.de> <20210916080253.GC59501@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Sep 16, 2021 at 11:14:01AM +0200, Michael Lawnick wrote: > Am 16.09.2021 um 10:02 schrieb AKASHI Takahiro: > > On Thu, Sep 16, 2021 at 09:48:07AM +0200, Michael Lawnick wrote: > > > Am 16.09.2021 um 09:15 schrieb Michael Lawnick: > > > > Am 16.09.2021 um 09:12 schrieb AKASHI Takahiro: > > > > > Please, as Heinrich suggested, add CONFIG_FS_FAT, in your U-Boot configuration. > > > > > > > > > Hmm, I didn't understand that as a suggestion, but as a question for his > > > > understanding. Of course I'll give it a try. > > > > > > > Sometimes live is such easy. This fixed my issue, THX. > > > > > > For the after-math / my understanding: > > > - Do I understand correctly that the problem was that 'efi_selftest > > > block device' requires FAT support? So shouldn't there be a dependency > > > in CONFIG? > > > > Strictly speaking, CONFIG_EFI_LOADER requires FAT per UEFI specification, > > and actually it has 'imply FAT'. I don't know why Heinrich uses 'imply' > > instead of 'select'. > > > > > - What is the reason/use to iterate through the recognized partitions > > > even twice (in .setup and .execute) if they aren't needed/used? > > > > What line of code do you exactly mean by 'in .setup' (and in .execute)? > > My understanding: > efi_selftests register their methods separated by setup/execute/teardown. > The central test control is taking tests from list and executes the > three methods, unaware of which exact test is executed: > lib/efi_selftest/efi_selftest.c That is exactly what efi_selftest.c does. > lib/efi_selftest/efi_selftest_block_device.c And this is a test instance for block device test. So what's your question? -Takahiro Akashi