From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E829C433EF for ; Thu, 16 Sep 2021 09:53:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61BD4611CA for ; Thu, 16 Sep 2021 09:53:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 61BD4611CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B286582E05; Thu, 16 Sep 2021 11:53:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="NKHYy2Vq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0C73082ECC; Thu, 16 Sep 2021 11:53:31 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0608.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2CD6782DB3 for ; Thu, 16 Sep 2021 11:53:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UCbV/brQW9bQQ/aa8nW+Wl2WwbErnirMakB1kv4vDBXs94m3EUBvWxk6cc6JrR9RS6Nv/JNNWcinFe3smddlI5P344O6n8rNwEJldHhCpdvvF+Jc+OdIkZknQGZmIOJYhKzdytMEbiepmYhFSXJtB+hZ2eIpIvvRG5tCs8qTTnXYRyemlbfjUOboK3Q/O2zw1OojyCgzQLs7Ya0fywUIq3nwV/5N3y3aj8J973DWnjFg1KQDDPnkSf4y+aMHfIBkQr5xfRJz27HzaE1YXFD3N8cZfyERg4zC5l5XTR5l0U39QjsM5RPn9Kl20/c705z00uFSeKNQSl/wP5I2+5uDig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NZaLBkh0yrFZhmDZHOfj/sEQNbbk3EsLUfLMfEXSjOg=; b=KJZxsSplGcL9n5OBID/8YT2CMetmNe5C8JBem11fFzXwcc13KNbJM/hoxLlAOvtFxDIZVWGhuwt2bKtDuiyelaeToYBJ4JEQ/MvwLFVUFdtCQX4mv9ClSBJfQA7wxdz0OGjQb6sem+sjTJ7nGpKdBV8k+cZPo/4f9N7qsrEvZFSslXIZR2UAt4c7jZWACsifzQouq7bQrvo1Qa/Na9NQIeXQhMyFS2YV7slV81OcHNAMbqecvuogZnrV2bPURIGqlyaN01PonE8OPfbgJsXkRVY1t6ne3J/ZcwMzbGr4u0qG5RWkFKOHy+eknvqaUFfE63sYPcRS/NdpfnzwtxdqbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NZaLBkh0yrFZhmDZHOfj/sEQNbbk3EsLUfLMfEXSjOg=; b=NKHYy2VqYk9VhSw5KTORpM7UMfKbPJ1sSc5tKDkvKEHz/FEpwl1+GquJnZd/s9sKUo8MOhwGFoMiCcsCQi4JqqSxYo3127nB6UPNQtXqIt2QfN99oGThTISb7JWJOekRrE4obO2tbLQtZdDybEsjY0691iCvd+MwvJdtb5rcVYE= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3711.eurprd04.prod.outlook.com (2603:10a6:803:18::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.18; Thu, 16 Sep 2021 09:53:23 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4500.019; Thu, 16 Sep 2021 09:53:23 +0000 From: Vladimir Oltean To: Michael Walle , Andy Tang CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v3 01/29] armv8: ls1028a: add IOMMU stream ID to vivante node Thread-Topic: [PATCH v3 01/29] armv8: ls1028a: add IOMMU stream ID to vivante node Thread-Index: AQHXoBoNZPNkAewTbEqJPemGqcyf+aumgSoA Date: Thu, 16 Sep 2021 09:53:23 +0000 Message-ID: <20210916095322.stmqnv2fezzbj2n3@skbuf> References: <20210902164558.1920849-1-michael@walle.cc> <20210902164558.1920849-2-michael@walle.cc> In-Reply-To: <20210902164558.1920849-2-michael@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 408a5fdb-ede9-4750-4eda-08d978f7d2ac x-ms-traffictypediagnostic: VI1PR0402MB3711: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ypgUVA9jYeFEVy+BDsXS5Mv+XPehm5iFrXF7Pk9AYYZ6XbbMhtK/VstgRg9LvA7vGvvNRItpfplBwhCmAC7jxRmN6vafg/j5AJ+/OK9bshdCX7YYLmd9zKUOEFhraEy3Te/kSTfRf4peGfS9ur5ZWRHLF4ZUSG+GXaPR/19wdluKYc9SjfnDeE9LGdR3R1pvue1SKcGVNbLY7FSxp9pnwNO0Clh1N6PJEJkaJojFvL5A6tWJ3E1qv+HfI40I2gi7E1z1X0TgHk0+HgiRd7ahBJnIBOOEk7irlg5X+6P+SxHQxWTP+D/DKgOHdWm96gzlGnuKBOFJD12SvcMmYjHWd9fUarTbq4h3WEgfv6PgQNGQvIJ3rg5r15RlW2fIVk+OjByw/ZkBtyguNVzVvB1PMS+v+zIYsj+BYZc7Hqi+5oOm3VYq0KEpIVy+ScqRvpzrFA/mt9O5euWkC5xSlBIX8+nTgUkg5bXKGV96a+crX6X4U9w/9NERlrMtmYuEb9NqfS0CWdeAtFVsO/MnOS7k8O+o529UYuFIWmwu5Q9UkksRAbB4cL5R32Sh2frYJtgiNPQsMHCilY3J1HhzFsFt1FBOxt4EG+frr80uECYV2VFm4ZDAjqU33cfJNohpRExcum1USfTUXJP2CYisnxU48JvSi8KMCXERycznIkN3v0PwI3mQoqFjrEsR18g484+r4fzWQPAaYk+mqKZPDcdo1Y1klcwJeWKwYq5Z2ORJzdiHmnNmJrvUh8GjGC0IY2tuYnb/B/irMKEZmoKfvHs2dcWGuLlQ/sMC1N4GUACuCZiUd0Y+wrCNROp68izk+Oik x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(7916004)(366004)(39860400002)(376002)(396003)(346002)(136003)(71200400001)(478600001)(5660300002)(316002)(83380400001)(186003)(1076003)(44832011)(2906002)(6636002)(6486002)(38070700005)(966005)(4326008)(8676002)(8936002)(33716001)(110136005)(38100700002)(86362001)(91956017)(64756008)(54906003)(66476007)(6512007)(76116006)(9686003)(66446008)(6506007)(122000001)(66556008)(26005)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3Y1QhAwdG4D//vzeRdIi554Ds34L9m+tKXFHkc7pb73z5YSloXTeVEjz4N+6?= =?us-ascii?Q?eA3gV7aOMxGS6RM8anFQ4pSMiazRKfZ5fcnwGiUparq9FI9uJ5oz+xNP2EKw?= =?us-ascii?Q?gJaogJ+cOkck9DnsBIoAmou3nIcNbViDO03aJ58ajCHNws0C+RveDRNjU12o?= =?us-ascii?Q?9jH8WXLn6zHiqrmcMSH/lv/rJbPzGcAmAj5pRpeGDmi9yCoe2El3eLC2QP+a?= =?us-ascii?Q?czfMRvV0LU4pz2bm2xmIr8M3bZJFiGsED6IO2p9hS+WHTR6LgtoQJ/z4e/MB?= =?us-ascii?Q?qThGnfTtLWgnYieY2xmO0wxPBmvZvavvPIAZ9VRvtMR1BDTG+Cx/10moDKsi?= =?us-ascii?Q?N03yxWXdIe2R+NX60Jl3ptpHocAIa0POkNx/EGGysA7bGXVKYTkEmih8a0ip?= =?us-ascii?Q?qzfw5i5qqjZo1hak9Ka0e8qs1nGykjq3x1SBAxuf87gedJL7YZfTC9O6G/ZA?= =?us-ascii?Q?VDKwVkdJkc9iWklP/XVU1dp523oYNVptaPJRNzednfQUF4rVz1xua+uO4tFQ?= =?us-ascii?Q?ZPfzY6njif5K8kH4JvfnGsRPWtS1adJstd17DqTKFie5RXP3CuQNTOucrqbD?= =?us-ascii?Q?gyUwsr1LyoexGMTXub6kOwFCUJu0wCaI6NwhrXA/hvBxUtABObhi9LeVcrwm?= =?us-ascii?Q?ea844uxMgdH4pJI0RDtHNnaACUxNGcpr5yzjL05pcJzOvFVAWkTAMvQ9bhHt?= =?us-ascii?Q?L7JKUlqRqvAfX9IzhiOGL5jULlLLH2tWjtr0q7PX4LF8qw5MTpOYX+aGLGlR?= =?us-ascii?Q?e/qxstnQIclT4p34gdelN808ODFv5cnGQyJNwTa19dZNFppXw+lWpy8uXNPQ?= =?us-ascii?Q?ZhIczRLBKxIJtT+ENUb4Z44E4of5BB5xD+zWudV7vRkmnbVdRS/6i3Mr8fY1?= =?us-ascii?Q?fnE56DUhEOpehnNjjYLthbAEFqP/g95OuncKLXZA5MHohBoqLTNmkAf/ysBz?= =?us-ascii?Q?SzO1tHFw5s0JpzONBru0CLzlXvjpt429gNk7iOncvHKL7TCC8AkJEGklpnFY?= =?us-ascii?Q?P9wAAks3mk/Ex5jbeparub81/sjMoT46VSZNI0V7MtQ4r/oLiBOfhnJOfiIz?= =?us-ascii?Q?ozvOWTHS7ojUTorhojuaxyA9tR9piMhmGDFfRAP76NTXu92l34U+OSr+yDt5?= =?us-ascii?Q?WTP3wxsWzZFm2SdT5RKUAYrScJr6GyU9xr6dxTaOFd05+1B7Oyf8LGaLMaLA?= =?us-ascii?Q?jTUCTLLV6qjVWVFVKV1r1xZR2bnfKBk4XRd4hCQTOtPkx5c8GZpZf7CC4eQj?= =?us-ascii?Q?ZnlHHBoc8xQ2ZbEDQw5fgxGwU/vnnMuWWyJLAC4mLVRJgBpYY+a844pRRxaq?= =?us-ascii?Q?hlidN3LDM5VIlQqa/VtL95yJ?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 408a5fdb-ede9-4750-4eda-08d978f7d2ac X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 09:53:23.4339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S3QptPSogtt3Fcw26RGnG4yrjPqRVNxVyaRAg5tcbpUHx8aiYSeZBZqUsP4ZVuCmXBmFfxJTSRkh8t2/RDMD4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3711 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Sep 02, 2021 at 06:45:30PM +0200, Michael Walle wrote: > The fixup is done for the "fsl,ls1028a-gpu" which isn't any official > device tree binding. Don't break it, but instead add a fixup for another > compatible "vivante,gc" which is the offical one for the GPU on the > LS1028A. >=20 > Signed-off-by: Michael Walle > --- > arch/arm/cpu/armv8/fsl-layerscape/ls1028_ids.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ls1028_ids.c b/arch/arm/cp= u/armv8/fsl-layerscape/ls1028_ids.c > index 49df8b3790..d93a793f39 100644 > --- a/arch/arm/cpu/armv8/fsl-layerscape/ls1028_ids.c > +++ b/arch/arm/cpu/armv8/fsl-layerscape/ls1028_ids.c > @@ -18,6 +18,7 @@ struct icid_id_table icid_tbl[] =3D { > SET_SATA_ICID(1, "fsl,ls1028a-ahci", FSL_SATA1_STREAM_ID), > SET_EDMA_ICID(FSL_EDMA_STREAM_ID), > SET_QDMA_ICID("fsl,ls1028a-qdma", FSL_DMA_STREAM_ID), > + SET_GPU_ICID("vivante,gc", FSL_GPU_STREAM_ID), > SET_GPU_ICID("fsl,ls1028a-gpu", FSL_GPU_STREAM_ID), > SET_DISPLAY_ICID(FSL_DISPLAY_STREAM_ID), > #ifdef CONFIG_FSL_CAAM > --=20 > 2.30.2 >=20 So I have zero tangency with the LS1028A GPU (I've just ordered a DisplayPort to HDMI adapter so I can test it from now on with my HDMI capture card), but I think that you know that the "fsl,ls1028a-gpu" compatible string is for this driver: https://source.codeaurora.org/external/qoriq/qoriq-components/linux/tree/dr= ivers/mxc/gpu-viv/hal/os/linux/kernel/platform/freescale/gc_hal_kernel_plat= form_imx.c?h=3DLSDK-21.08 which yes, has no upstream equivalent, and will probably never be upstream. And by the way, every time I boot an upstream kernel with upstream U-Boot, I get this warning due to the attempted fixup, which is really anno= ying: WARNING could not find node fsl,ls1028a-gpu: FDT_ERR_NOTFOUND. So I personally would not mind if we would just delete anything having to do with "fsl,ls1028a-gpu" from mainline U-Boot (at least until something meaningful gets added to Linux which is specific to the LS1028A) :) Let me add Andy Tang to the discussion just to make sure that he's aware of what you're up to: https://www.spinics.net/lists/kernel/msg4060045.html=