public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Marek Behún" <behunmarek@gmail.com>
To: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: u-boot@lists.denx.de, "Priyanka Jain" <priyanka.jain@nxp.com>,
	"Heiko Schocher" <hs@denx.de>, "Marek Vasut" <marex@denx.de>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Christophe KERELLO" <christophe.kerello@foss.st.com>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Pali Rohár" <pali@kernel.org>, "Vignesh R" <vigneshr@ti.com>,
	"U-Boot STM32" <uboot-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH v3 2/2] mtd: spi: nor: force mtd name to "nor%d"
Date: Thu, 16 Sep 2021 16:49:37 +0200	[thread overview]
Message-ID: <20210916164937.6b87b1ff@thinkpad> (raw)
In-Reply-To: <20210916155040.v3.2.Ia461e670c7438478aa8f8939209d45c818ccd284@changeid>

On Thu, 16 Sep 2021 16:01:18 +0200
Patrick Delaunay <patrick.delaunay@foss.st.com> wrote:

> Force the mtd name of spi-nor to "nor" + the driver sequence number:
> "nor0", "nor1"... beginning after the existing nor devices.
> 
> This patch is coherent with existing "nand" and "spi-nand"
> mtd device names.
> 
> When CFI MTD NOR device are supported, the spi-nor index is chosen after
> the last CFI device defined by CONFIG_SYS_MAX_FLASH_BANKS.
> 
> When CONFIG_SYS_MAX_FLASH_BANKS_DETECT is activated, this config
> is replaced by to cfi_flash_num_flash_banks in the include file
> mtd/cfi_flash.h.
> 
> This generic name "nor%d" can be use to identify the mtd spi-nor device
> without knowing the real device name or the DT path of the device,
> used with API get_mtd_device_nm() and is used in mtdparts command.
> 
> This patch also avoids issue when the same NOR device is present 2 times,
> for example on STM32MP15F-EV1:

This is an unfortunate hack :( This is another reason why the whole mtd
subsystem should be refactored.

  reply	other threads:[~2021-09-17  3:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 14:01 [PATCH v3 0/2] mtd: spi: nor: force mtd name to "nor%d" Patrick Delaunay
2021-09-16 14:01 ` [PATCH v3 1/2] mtd: cfi_flash: use cfi_flash_num_flash_banks only when supported Patrick Delaunay
2021-09-16 17:24   ` Marek Vasut
2021-09-17 10:55   ` Patrick DELAUNAY
2021-09-17 13:36     ` Marek Vasut
2021-09-21 12:38       ` Patrick DELAUNAY
2021-09-16 14:01 ` [PATCH v3 2/2] mtd: spi: nor: force mtd name to "nor%d" Patrick Delaunay
2021-09-16 14:49   ` Marek Behún [this message]
2021-09-16 15:00   ` Marek Behún
2021-09-16 17:27   ` Marek Vasut
2021-09-17 13:06   ` Patrick DELAUNAY
2021-09-17 13:39     ` Marek Vasut
2021-09-16 17:43 ` [PATCH v3 0/2] " Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210916164937.6b87b1ff@thinkpad \
    --to=behunmarek@gmail.com \
    --cc=christophe.kerello@foss.st.com \
    --cc=hs@denx.de \
    --cc=jagan@amarulasolutions.com \
    --cc=marex@denx.de \
    --cc=miquel.raynal@bootlin.com \
    --cc=pali@kernel.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=priyanka.jain@nxp.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-stm32@st-md-mailman.stormreply.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox