From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E259C433EF for ; Thu, 16 Sep 2021 19:42:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D65B61212 for ; Thu, 16 Sep 2021 19:42:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2D65B61212 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 630048314A; Thu, 16 Sep 2021 21:42:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HnGnt9KG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B1EE28314A; Thu, 16 Sep 2021 21:42:27 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EED2882FC0 for ; Thu, 16 Sep 2021 21:42:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id x5so6637462qtq.13 for ; Thu, 16 Sep 2021 12:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NCuuuLnhCY67zNRV5uVSzI4DNdPhM42udc2lNloyZts=; b=HnGnt9KGAtFL27EHhF+7/YFO4+AUgC8AKLqO/EmaMntzR4dwp9fiob16Jx/9/33Yiz xLoeWSML0jdH2MnhUWUpDJWoyDPmvxvgF0rtf6KnqLC9pX8t3koDRlZtk1GeFTQbfGgg u/Nil+SgfLyg5X1NmJ8tvMsLxVoelkilSOwsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NCuuuLnhCY67zNRV5uVSzI4DNdPhM42udc2lNloyZts=; b=XYi6LZHMb1Nqm3ed5Ag7/8DmCzaGrWW0K7edFtOsoCrjBqEVEFrYmY6YOX7gl8MX3g XiZjaQzTj6SNewdwBo7ffWycx30nn4PZlw6cMVaxzvJPSVnHfSnh8XWBw00+KqrpwZZO YLWq6sLAdzUt63G3KglU8XLb84nIQjjKdXXxf68yr94zDR+zTRVsqYI6sbaMtLN+C8iZ NNU7w6YWTCa2oH/yp2J2JsQcP1gRbHksVc0Xa6HcLBXfFXf7+e6bqL41QZxDkCVR8Y1M E51cwACa1KlLemZuFd2ttt/9EyfCe0Y0hiaSwucoEk/6uBVl3AOzeNHto4eH/34nQP+A h5Gg== X-Gm-Message-State: AOAM533QxmG9IpAcLa0M4EO6AJ+fKd/Eek81dsKiC1ORak7SCH/Gja6X AeSy4giHFkLZEX4k9boh+KoyDMlxVTsDzA== X-Google-Smtp-Source: ABdhPJy15/Vq6lbg71Kawqv+ktCf5ci7Pc1/1+w3K0Aw667YvamHUeHx9sOx2nf4CQzSDAZt3FV6SQ== X-Received: by 2002:ac8:724c:: with SMTP id l12mr6732791qtp.131.1631821342752; Thu, 16 Sep 2021 12:42:22 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-d880-4580-a9ce-9f2f.res6.spectrum.com. [2603:6081:7b01:cbda:d880:4580:a9ce:9f2f]) by smtp.gmail.com with ESMTPSA id m187sm3081251qkd.131.2021.09.16.12.42.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Sep 2021 12:42:22 -0700 (PDT) Date: Thu, 16 Sep 2021 15:42:20 -0400 From: Tom Rini To: Francesco Dolcini Cc: u-boot@lists.denx.de Subject: Re: [PATCH] xtensa: Put U-Boot version string at correct place by linker script Message-ID: <20210916194220.GA3997@bill-the-cat> References: <20210802131838.21097-7-pali@kernel.org> <20210916173021.3347-1-trini@konsulko.com> <20210916193819.GA285648@francesco-nb.int.toradex.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO" Content-Disposition: inline In-Reply-To: <20210916193819.GA285648@francesco-nb.int.toradex.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 16, 2021 at 09:38:19PM +0200, Francesco Dolcini wrote: > On Thu, Sep 16, 2021 at 01:30:21PM -0400, Tom Rini wrote: > > *(.literal .text) \ > > + *(.literal .text_version_string) \ >=20 > Isn't ".litteral" a duplication? Even if I'm pretty sure it will not caus= e any difference > in the generated binary I would remove it. Honestly, I don't know xtensa. We also don't have qemu support for it currently, and I'm a bit worried in general about the state of the platform (it's on my TODO list to poke some people now). So, I hesitate to make any change that's not basically copy/paste of the existing lines. --=20 Tom --2oS5YaxWCcQjTEyO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFDnhUACgkQFHw5/5Y0 tyznaAv9EM920inzAzNwDd7Ov1CODBq6FoHfKsw5fsDlSG9Vu/s9k6+7khbgwRyj cDu0pnBzdx4gTrUSJN1ZmZAUh1IpPhyzLQXr3JKIX+HmPzD/Tv6KERuQF1HS2443 5OK1GsWP919u6yGliETAuBr4064QaSSE/80sZgz0MboUGc0//JQXK/fIkTYQopp5 jjthee0MtOPgKVQmwvbgKgbCiw8mH1Z5DV77TmE6C1t5N/k8S1OGm8M7Z473ozBj gouc/dm7iVpkP7Gpv0FueJuoVGSw07CaB5eX1Ab/gMQRklHw6LUB+vH02eCTfJMx beCppAyPLJkks72/cKxnhdwzr0b5IjOUQqpbqy5PlxDnvitWrr8dHk0smMNanKMR hZ4f1fhKQW3yTlEiW+NQno7Dtz9+GcjgKYYTLu8/amiYXWn9iVa5V4L9A/M7YHrU Bt3OYlEEAbJ/owG6WIaEtMcI13sSIWv4ZhPjZFVMcYVioFnTDK/WRNxMqP7LX73m hgjd2ZL/ =64UA -----END PGP SIGNATURE----- --2oS5YaxWCcQjTEyO--