From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Richard Genoud <richard.genoud@posteo.net>,
Joao Marcos Costa <jmcosta944@gmail.com>,
Sean Anderson <sean.anderson@seco.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] fs: avoid superfluous messages
Date: Fri, 17 Sep 2021 14:34:43 +0900 [thread overview]
Message-ID: <20210917053443.GA93050@laputa> (raw)
In-Reply-To: <20210916081020.44508-1-heinrich.schuchardt@canonical.com>
On Thu, Sep 16, 2021 at 10:10:20AM +0200, Heinrich Schuchardt wrote:
> Output like the following is quite irritating:
>
> => bootefi hello
> Scanning disk mmc2.blk...
> No valid Btrfs found
> Bad magic number for SquashFS image.
> ** Unrecognized filesystem type **
> Scanning disk mmc1.blk...
> No valid Btrfs found
> Bad magic number for SquashFS image.
> ** Unrecognized filesystem type **
> Scanning disk mmc0.blk...
> No valid Btrfs found
> Bad magic number for SquashFS image.
> ** Unrecognized filesystem type **
>
> It is expected that a whole disk (partition number 0) doesn't contain a
> filesystem.
A whole disk *can* contain a filesystem in general.
Please correct the commit message.
-Takahiro Akashi
> Partitions may only contain a blob. This situation is only
> worth a debug message.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> fs/fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs.c b/fs/fs.c
> index 7c682582c8..023f89cafe 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -37,7 +37,7 @@ static int fs_type = FS_TYPE_ANY;
> static inline int fs_probe_unsupported(struct blk_desc *fs_dev_desc,
> struct disk_partition *fs_partition)
> {
> - log_err("** Unrecognized filesystem type **\n");
> + log_debug("Unrecognized filesystem type\n");
> return -1;
> }
>
> --
> 2.32.0
>
prev parent reply other threads:[~2021-09-17 5:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 8:10 [PATCH 1/1] fs: avoid superfluous messages Heinrich Schuchardt
2021-09-16 9:35 ` Mark Kettenis
2021-09-16 9:53 ` Mark Kettenis
2021-09-17 5:34 ` AKASHI Takahiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917053443.GA93050@laputa \
--to=takahiro.akashi@linaro.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=jmcosta944@gmail.com \
--cc=richard.genoud@posteo.net \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox