From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E5FC433F5 for ; Fri, 17 Sep 2021 05:34:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AF51610C9 for ; Fri, 17 Sep 2021 05:34:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8AF51610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3520582EE0; Fri, 17 Sep 2021 07:34:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="c+j6yoan"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5E4D682F34; Fri, 17 Sep 2021 07:34:53 +0200 (CEST) Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 23B0282E03 for ; Fri, 17 Sep 2021 07:34:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x42b.google.com with SMTP id j16so8171308pfc.2 for ; Thu, 16 Sep 2021 22:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=z7NJ076RGvWSGG7jN9+swKKhJuE/Y2KkJuMnihmKcEE=; b=c+j6yoang6Yj0qOtSuW3TIAI14FBYNG0Vgy3cM3ui3O7XwXkG54N7Q97NbkbFkTzb0 7Xma9F9sSbXj4+hEKIlJKDhq3wcjISs5Vg2ZFm4XyMc2MfDJH357+3sMYgl7UOTZgYV0 2qgPhdUDzgh9Kj7tYIxx3MReDi6btYlJSoOCfNN7x6F7ZgErc/fZ+6yPDix54yrHdVTM DAAbmxuECVOl3WtTWd4rxrQL5hnh6g7HJGCQISn5eF7Rt1UrziIl622QuPXzaPsicGX2 Hj7ovo4hsX5OhNElBttDW3ZDixW6hebE2R2F2i/LaPce25eq2H8lMv21zboIku6PLO9X tvFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=z7NJ076RGvWSGG7jN9+swKKhJuE/Y2KkJuMnihmKcEE=; b=6Yu735fIz4L3piJmjSy2cT39tZkIXVAZ6PN3l4cqsKKDI/Gka9xcEfjOhAgtwDk1Qf lEGLuv7mfavcGkuoi/ycYkHlsjLyTEjrjMSKVBs3hks8WfzHtBOLaAhelQUWkUSZqWau 89w3qBVW4EU1Y4aQGDq/noGFq7oJg/qnG22ce9GRspiu7+/Q0ecgodR9GxKIjo5Rlxm1 VGY8lG+e+yAGUU2/3crPSXDBrOFkrt8BnHUst6dajZ/JK97LYlWB3NkHOU0RJFzY/l1n oWLlfa2Ae9fQH2/LncxKyN/5H6M86tQB/vNZF9LIvvndtKhWaPofL2pLssIQilJaE4gL k5Gw== X-Gm-Message-State: AOAM531CYIf0stVc9RI7MFKOY7rXCankGbBJt3bCOpntoowJyuWkdNBY mPZyHYMpgZia12Vc4RHNY9DzBA== X-Google-Smtp-Source: ABdhPJwVMP0HK6yjO90179DTgGcAExLKZYjr2SiT+cubr6tVnNqND1Gxlp+gCmTqLpmTh6VYHHsOlw== X-Received: by 2002:a63:9217:: with SMTP id o23mr8335254pgd.178.1631856888181; Thu, 16 Sep 2021 22:34:48 -0700 (PDT) Received: from laputa (p6e421539.tkyea130.ap.so-net.ne.jp. [110.66.21.57]) by smtp.gmail.com with ESMTPSA id i27sm4774701pfq.184.2021.09.16.22.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 22:34:47 -0700 (PDT) Date: Fri, 17 Sep 2021 14:34:43 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Tom Rini , Simon Glass , Richard Genoud , Joao Marcos Costa , Sean Anderson , u-boot@lists.denx.de Subject: Re: [PATCH 1/1] fs: avoid superfluous messages Message-ID: <20210917053443.GA93050@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Tom Rini , Simon Glass , Richard Genoud , Joao Marcos Costa , Sean Anderson , u-boot@lists.denx.de References: <20210916081020.44508-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916081020.44508-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Sep 16, 2021 at 10:10:20AM +0200, Heinrich Schuchardt wrote: > Output like the following is quite irritating: > > => bootefi hello > Scanning disk mmc2.blk... > No valid Btrfs found > Bad magic number for SquashFS image. > ** Unrecognized filesystem type ** > Scanning disk mmc1.blk... > No valid Btrfs found > Bad magic number for SquashFS image. > ** Unrecognized filesystem type ** > Scanning disk mmc0.blk... > No valid Btrfs found > Bad magic number for SquashFS image. > ** Unrecognized filesystem type ** > > It is expected that a whole disk (partition number 0) doesn't contain a > filesystem. A whole disk *can* contain a filesystem in general. Please correct the commit message. -Takahiro Akashi > Partitions may only contain a blob. This situation is only > worth a debug message. > > Signed-off-by: Heinrich Schuchardt > --- > fs/fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fs.c b/fs/fs.c > index 7c682582c8..023f89cafe 100644 > --- a/fs/fs.c > +++ b/fs/fs.c > @@ -37,7 +37,7 @@ static int fs_type = FS_TYPE_ANY; > static inline int fs_probe_unsupported(struct blk_desc *fs_dev_desc, > struct disk_partition *fs_partition) > { > - log_err("** Unrecognized filesystem type **\n"); > + log_debug("Unrecognized filesystem type\n"); > return -1; > } > > -- > 2.32.0 >