* [PATCH 1/1] fs: avoid superfluous messages
@ 2021-09-16 8:10 Heinrich Schuchardt
2021-09-16 9:35 ` Mark Kettenis
2021-09-17 5:34 ` AKASHI Takahiro
0 siblings, 2 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2021-09-16 8:10 UTC (permalink / raw)
To: Tom Rini
Cc: Simon Glass, Richard Genoud, Joao Marcos Costa, Sean Anderson,
u-boot, Heinrich Schuchardt
Output like the following is quite irritating:
=> bootefi hello
Scanning disk mmc2.blk...
No valid Btrfs found
Bad magic number for SquashFS image.
** Unrecognized filesystem type **
Scanning disk mmc1.blk...
No valid Btrfs found
Bad magic number for SquashFS image.
** Unrecognized filesystem type **
Scanning disk mmc0.blk...
No valid Btrfs found
Bad magic number for SquashFS image.
** Unrecognized filesystem type **
It is expected that a whole disk (partition number 0) doesn't contain a
filesystem. Partitions may only contain a blob. This situation is only
worth a debug message.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
fs/fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fs.c b/fs/fs.c
index 7c682582c8..023f89cafe 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -37,7 +37,7 @@ static int fs_type = FS_TYPE_ANY;
static inline int fs_probe_unsupported(struct blk_desc *fs_dev_desc,
struct disk_partition *fs_partition)
{
- log_err("** Unrecognized filesystem type **\n");
+ log_debug("Unrecognized filesystem type\n");
return -1;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] fs: avoid superfluous messages
2021-09-16 8:10 [PATCH 1/1] fs: avoid superfluous messages Heinrich Schuchardt
@ 2021-09-16 9:35 ` Mark Kettenis
2021-09-16 9:53 ` Mark Kettenis
2021-09-17 5:34 ` AKASHI Takahiro
1 sibling, 1 reply; 4+ messages in thread
From: Mark Kettenis @ 2021-09-16 9:35 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: trini, sjg, richard.genoud, jmcosta944, sean.anderson, u-boot,
heinrich.schuchardt
> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Date: Thu, 16 Sep 2021 10:10:20 +0200
>
> Output like the following is quite irritating:
>
> => bootefi hello
> Scanning disk mmc2.blk...
> No valid Btrfs found
> Bad magic number for SquashFS image.
> ** Unrecognized filesystem type **
> Scanning disk mmc1.blk...
> No valid Btrfs found
> Bad magic number for SquashFS image.
> ** Unrecognized filesystem type **
> Scanning disk mmc0.blk...
> No valid Btrfs found
> Bad magic number for SquashFS image.
> ** Unrecognized filesystem type **
>
> It is expected that a whole disk (partition number 0) doesn't contain a
> filesystem. Partitions may only contain a blob. This situation is only
> worth a debug message.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> fs/fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Cool. Thanks. That removes a lot of clutter when booting OpenBSD on
my Apple M1 mini ;).
> diff --git a/fs/fs.c b/fs/fs.c
> index 7c682582c8..023f89cafe 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -37,7 +37,7 @@ static int fs_type = FS_TYPE_ANY;
> static inline int fs_probe_unsupported(struct blk_desc *fs_dev_desc,
> struct disk_partition *fs_partition)
> {
> - log_err("** Unrecognized filesystem type **\n");
> + log_debug("Unrecognized filesystem type\n");
> return -1;
> }
>
> --
> 2.32.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] fs: avoid superfluous messages
2021-09-16 9:35 ` Mark Kettenis
@ 2021-09-16 9:53 ` Mark Kettenis
0 siblings, 0 replies; 4+ messages in thread
From: Mark Kettenis @ 2021-09-16 9:53 UTC (permalink / raw)
To: Mark Kettenis
Cc: heinrich.schuchardt, trini, sjg, richard.genoud, jmcosta944,
sean.anderson, u-boot, heinrich.schuchardt
> Date: Thu, 16 Sep 2021 11:35:19 +0200 (CEST)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
>
> > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > Date: Thu, 16 Sep 2021 10:10:20 +0200
> >
> > Output like the following is quite irritating:
> >
> > => bootefi hello
> > Scanning disk mmc2.blk...
> > No valid Btrfs found
> > Bad magic number for SquashFS image.
> > ** Unrecognized filesystem type **
> > Scanning disk mmc1.blk...
> > No valid Btrfs found
> > Bad magic number for SquashFS image.
> > ** Unrecognized filesystem type **
> > Scanning disk mmc0.blk...
> > No valid Btrfs found
> > Bad magic number for SquashFS image.
> > ** Unrecognized filesystem type **
> >
> > It is expected that a whole disk (partition number 0) doesn't contain a
> > filesystem. Partitions may only contain a blob. This situation is only
> > worth a debug message.
> >
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > ---
> > fs/fs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Cool. Thanks. That removes a lot of clutter when booting OpenBSD on
> my Apple M1 mini ;).
I accidentally deleted the other two diffs from my inbox, but those
looked good too.
> > diff --git a/fs/fs.c b/fs/fs.c
> > index 7c682582c8..023f89cafe 100644
> > --- a/fs/fs.c
> > +++ b/fs/fs.c
> > @@ -37,7 +37,7 @@ static int fs_type = FS_TYPE_ANY;
> > static inline int fs_probe_unsupported(struct blk_desc *fs_dev_desc,
> > struct disk_partition *fs_partition)
> > {
> > - log_err("** Unrecognized filesystem type **\n");
> > + log_debug("Unrecognized filesystem type\n");
> > return -1;
> > }
> >
> > --
> > 2.32.0
> >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] fs: avoid superfluous messages
2021-09-16 8:10 [PATCH 1/1] fs: avoid superfluous messages Heinrich Schuchardt
2021-09-16 9:35 ` Mark Kettenis
@ 2021-09-17 5:34 ` AKASHI Takahiro
1 sibling, 0 replies; 4+ messages in thread
From: AKASHI Takahiro @ 2021-09-17 5:34 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Tom Rini, Simon Glass, Richard Genoud, Joao Marcos Costa,
Sean Anderson, u-boot
On Thu, Sep 16, 2021 at 10:10:20AM +0200, Heinrich Schuchardt wrote:
> Output like the following is quite irritating:
>
> => bootefi hello
> Scanning disk mmc2.blk...
> No valid Btrfs found
> Bad magic number for SquashFS image.
> ** Unrecognized filesystem type **
> Scanning disk mmc1.blk...
> No valid Btrfs found
> Bad magic number for SquashFS image.
> ** Unrecognized filesystem type **
> Scanning disk mmc0.blk...
> No valid Btrfs found
> Bad magic number for SquashFS image.
> ** Unrecognized filesystem type **
>
> It is expected that a whole disk (partition number 0) doesn't contain a
> filesystem.
A whole disk *can* contain a filesystem in general.
Please correct the commit message.
-Takahiro Akashi
> Partitions may only contain a blob. This situation is only
> worth a debug message.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> fs/fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs.c b/fs/fs.c
> index 7c682582c8..023f89cafe 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -37,7 +37,7 @@ static int fs_type = FS_TYPE_ANY;
> static inline int fs_probe_unsupported(struct blk_desc *fs_dev_desc,
> struct disk_partition *fs_partition)
> {
> - log_err("** Unrecognized filesystem type **\n");
> + log_debug("Unrecognized filesystem type\n");
> return -1;
> }
>
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-17 5:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-16 8:10 [PATCH 1/1] fs: avoid superfluous messages Heinrich Schuchardt
2021-09-16 9:35 ` Mark Kettenis
2021-09-16 9:53 ` Mark Kettenis
2021-09-17 5:34 ` AKASHI Takahiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox