From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Jaehoon Chung <jh80.chung@samsung.com>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 10/11] sandbox: mmc: Support a backing file
Date: Sat, 18 Sep 2021 09:16:28 -0400 [thread overview]
Message-ID: <20210918131628.GL8579@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ1-8pdy-Fia2WDvdwvQq=iaKd=a=HqY5huNBZYcD0Kyqg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
On Sat, Sep 18, 2021 at 03:34:54AM -0600, Simon Glass wrote:
> Hi Tom,
>
> On Thu, 16 Sept 2021 at 12:40, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Wed, Aug 18, 2021 at 09:40:32PM -0600, Simon Glass wrote:
> >
> > > Provide a way for sandbox MMC to present data from a backing file. This
> > > allows a filesystem to be created on the host and easily served via an
> > > emulated mmc device.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
> > > ---
> > >
> > > doc/device-tree-bindings/mmc/sandbox,mmc.txt | 18 ++++++++
> > > drivers/mmc/sandbox_mmc.c | 46 ++++++++++++++++----
> > > 2 files changed, 55 insertions(+), 9 deletions(-)
> > > create mode 100644 doc/device-tree-bindings/mmc/sandbox,mmc.txt
> >
> > As is, this breaks how I've always run pytests on sandbox.
>
> How does it break it? Do you get an error? The feature is supposed to
> be optional.
Without doing anything to enable it, a few of the mmc unit tests failed.
I don't have the logs handy right now (I made that sometimes bad
decision to test 2 series at once, and now I'm waiting a bit more on
final feedback on the changes the timestamp cleanup needed before I push
that + the rest of this series).
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-09-18 13:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 3:40 [PATCH 00/11] sandbox: Minor fixes and improvements Simon Glass
2021-08-19 3:40 ` [PATCH 01/11] dtoc: Further improve documentation about warnings Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 02/11] sandbox: Correct handling of --rm_memory Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 03/11] sandbox: Add license headers to the dts files Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 04/11] btrfs: Suppress the message about missing filesystem Simon Glass
2021-08-19 10:31 ` Marek Behún
2021-08-19 10:48 ` Qu Wenruo
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 05/11] sqfs: " Simon Glass
2021-08-19 7:03 ` Miquel Raynal
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 06/11] test: Tidy a comment in the bloblist test Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 07/11] dm: core: Fix a few incorrect comments on first/next functions Simon Glass
2021-09-23 2:09 ` Tom Rini
2021-08-19 3:40 ` [PATCH 08/11] sandbox: Add a way to find the size of a file Simon Glass
2021-08-19 10:27 ` Marek Behún
2021-09-23 2:09 ` Tom Rini
2021-08-19 3:40 ` [PATCH 09/11] sandbox: Add a way to map a file into memory Simon Glass
2021-08-19 10:28 ` Marek Behún
2021-09-23 2:09 ` Tom Rini
2021-09-24 2:48 ` Simon Glass
2021-08-19 3:40 ` [PATCH 10/11] sandbox: mmc: Support a backing file Simon Glass
2021-08-28 5:15 ` Jaehoon Chung
2021-08-28 6:39 ` Sean Anderson
2021-09-18 9:34 ` Simon Glass
2021-09-16 18:40 ` Tom Rini
2021-09-18 9:34 ` Simon Glass
2021-09-18 13:16 ` Tom Rini [this message]
2021-09-18 16:31 ` Simon Glass
2021-09-20 3:18 ` Simon Glass
2021-10-21 20:17 ` Simon Glass
2021-08-19 3:40 ` [PATCH 11/11] test: Add a way to skip console checking until a string matches Simon Glass
2021-09-23 2:09 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210918131628.GL8579@bill-the-cat \
--to=trini@konsulko.com \
--cc=jh80.chung@samsung.com \
--cc=peng.fan@nxp.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox