public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: u-boot@lists.denx.de, Fabio Estevam <festevam@gmail.com>,
	"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
	Stefano Babic <sbabic@denx.de>
Subject: Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing
Date: Thu, 23 Sep 2021 07:36:34 -0400	[thread overview]
Message-ID: <20210923113634.GC31748@bill-the-cat> (raw)
In-Reply-To: <20210923075521.553577-1-francesco.dolcini@toradex.com>

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On Thu, Sep 23, 2021 at 09:55:21AM +0200, Francesco Dolcini wrote:

> colibri-imx6ull ethernet device is fec2, while the optional secondary
> ethernet is fec1, update the ethernet aliases in the .dts file so that
> ethaddr is set to fec2 and eth1addr to fec1.
> 
> Without this change the ethernet interfaces have a different
> mac address between Linux and U-Boot.
> 
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> ---
> 
>  arch/arm/dts/imx6ull-colibri.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/dts/imx6ull-colibri.dtsi b/arch/arm/dts/imx6ull-colibri.dtsi
> index b7bf79f28c..104207be97 100644
> --- a/arch/arm/dts/imx6ull-colibri.dtsi
> +++ b/arch/arm/dts/imx6ull-colibri.dtsi
> @@ -8,6 +8,12 @@
>  #include "imx6ull.dtsi"
>  
>  / {
> +	/* Ethernet aliases to ensure correct MAC addresses */
> +	aliases {
> +		ethernet0 = &fec2;
> +		ethernet1 = &fec1;
> +	};
> +
>  	chosen {
>  		stdout-path = &uart1;
>  	};

The main dts* files aren't supposed to change between U-Boot and Linux.
Is this re-syncing the file with current upstream then?  Thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2021-09-23 11:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23  7:55 [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing Francesco Dolcini
2021-09-23 11:36 ` Tom Rini [this message]
2021-09-23 11:50   ` Francesco Dolcini
2021-09-23 11:57     ` Tom Rini
2022-02-04 17:41       ` Marcel Ziswiler
2022-02-04 17:55 ` Fabio Estevam
2022-04-01 12:57   ` Marcel Ziswiler
2022-04-01 13:43     ` Tom Rini
2022-04-01 14:01       ` Marcel Ziswiler
2022-04-01 14:02         ` Tom Rini
2022-04-01 14:04         ` Tom Rini
2022-04-01 14:05           ` Francesco Dolcini
2022-04-01 14:28 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210923113634.GC31748@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox