From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5785DC433EF for ; Thu, 23 Sep 2021 11:58:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9828761107 for ; Thu, 23 Sep 2021 11:58:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9828761107 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 591A9833BB; Thu, 23 Sep 2021 13:58:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="X7zAlcRf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 94FFC833BB; Thu, 23 Sep 2021 13:58:08 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 92E95833B8 for ; Thu, 23 Sep 2021 13:58:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id q125so6465957qkd.12 for ; Thu, 23 Sep 2021 04:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8icElzJd5tzQ5pTonRlLuMlxeR8Sg2xm98MvL9F0g2I=; b=X7zAlcRfGbAzEp9ruTuEKXETtbl8vuOGQb06P4r2XZiHKVe76GgJVKMH0xssKFbrTS eqkrns/gbgk6RFKbH6XjHkRb/DQ8iJ8BV9wLrJYNNUCokSgmhCYNhBriKKCUoBRr27BN qReK+XrfL/w0aA0GLC7ANN3aH2X04Y07d5hV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8icElzJd5tzQ5pTonRlLuMlxeR8Sg2xm98MvL9F0g2I=; b=nkc98FyJxFXn34TTEH6VC2okRUo5dEOiTp4sV6S/d1bCp+Vz2cJweDNQsd3OVJsLfa yi9RL8k2VjTMLBXvuSU0xTkJwdyz+7E5Ydl3YYUAvvbKXi11N/KSUJwYs2YpnJJps5ZQ GQxP6Oy9byFv9iLTvxbm9xN+Mtu3eDbZ6XX2QUoHYb2G7phtTUcNfAiocp19vkAX2M2o 9zOTsDOkTZ+w7srFUvpaBiuQVckgnunBwVNy2B1f4MP0cRPgGtxlaO1V/37+A4QERsVg HNINMVbj16LG78S3lsllBf6C/y+HXZNDkWEq8AV51QziYwxve7rpQ34PUA4uEXExWX4+ JqIQ== X-Gm-Message-State: AOAM5318F5G5Hu9T51f7ZCF1ivSBiHbMPQ1vKG0QKgKzjnk+Wv+rtqv4 H8nIvw9ynUePwm7gBQRRUnaQ6Q== X-Google-Smtp-Source: ABdhPJxVd3zWMREI/Sd1wybzgvqB1sOxteIqmVZCsVSR6l9THpuqiIKz+dle58qhdHtxS7/TTLg/ZQ== X-Received: by 2002:a37:46d6:: with SMTP id t205mr4478350qka.131.1632398282195; Thu, 23 Sep 2021 04:58:02 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a58e-d475-4878-38e2.res6.spectrum.com. [2603:6081:7b01:cbda:a58e:d475:4878:38e2]) by smtp.gmail.com with ESMTPSA id m27sm3874447qkm.57.2021.09.23.04.58.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Sep 2021 04:58:01 -0700 (PDT) Date: Thu, 23 Sep 2021 07:57:59 -0400 From: Tom Rini To: Francesco Dolcini Cc: u-boot@lists.denx.de, Fabio Estevam , "NXP i.MX U-Boot Team" , Stefano Babic Subject: Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing Message-ID: <20210923115759.GD31748@bill-the-cat> References: <20210923075521.553577-1-francesco.dolcini@toradex.com> <20210923113634.GC31748@bill-the-cat> <20210923115041.GA546516@francesco-nb.int.toradex.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l21Zc9uzwusa2dXo" Content-Disposition: inline In-Reply-To: <20210923115041.GA546516@francesco-nb.int.toradex.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --l21Zc9uzwusa2dXo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 23, 2021 at 01:50:41PM +0200, Francesco Dolcini wrote: > On Thu, Sep 23, 2021 at 07:36:34AM -0400, Tom Rini wrote: > > On Thu, Sep 23, 2021 at 09:55:21AM +0200, Francesco Dolcini wrote: > >=20 > > > colibri-imx6ull ethernet device is fec2, while the optional secondary > > > ethernet is fec1, update the ethernet aliases in the .dts file so that > > > ethaddr is set to fec2 and eth1addr to fec1. > > >=20 > > > Without this change the ethernet interfaces have a different > > > mac address between Linux and U-Boot. > > >=20 > > > Signed-off-by: Francesco Dolcini > > >=20 > > > --- > > >=20 > > > arch/arm/dts/imx6ull-colibri.dtsi | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > >=20 > > > diff --git a/arch/arm/dts/imx6ull-colibri.dtsi b/arch/arm/dts/imx6ull= -colibri.dtsi > > > index b7bf79f28c..104207be97 100644 > > > --- a/arch/arm/dts/imx6ull-colibri.dtsi > > > +++ b/arch/arm/dts/imx6ull-colibri.dtsi > > > @@ -8,6 +8,12 @@ > > > #include "imx6ull.dtsi" > > > =20 > > > / { > > > + /* Ethernet aliases to ensure correct MAC addresses */ > > > + aliases { > > > + ethernet0 =3D &fec2; > > > + ethernet1 =3D &fec1; > > > + }; > > > + > > > chosen { > > > stdout-path =3D &uart1; > > > }; > >=20 > > The main dts* files aren't supposed to change between U-Boot and Linux. > > Is this re-syncing the file with current upstream then? Thanks. >=20 > Currently they are out of sync, correct, and because of this difference o= n the > ethernet aliases we have the situation in which the MAC address assigned = to the > ethernet interfaces is different between Linux an U-Boot. OK, we can take this now as an important bugfix. > There are other differences that this patchset is not trying to address a= nd > that are not causing any known issues. Please plan to sync the trees up for the next merge window, they are not supposed to stay out of sync. Thanks. --=20 Tom --l21Zc9uzwusa2dXo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFMa8QACgkQFHw5/5Y0 tyzQmgv/exyUC3nz9ifWEcmqcNp8noRXiyi7dRq062jDHJ/0LXl8PXc2YNpdC9qR nwNuUAEwe8SDAOp+Ql9Kvg94DQGHgLcqHl4ZwSfAXNJ0wb+ptx8cRufi2cOSMVek ggDPzKrGqHOM+70ZUzEO+1Kbd/WZ4g3jdICvvxlNrBJb+eTZuF9gGXJbm1hfmSwf KNM0Ort+y6f+6JkfdhNX/Z+PvInSfUihw6JAjmv5TAqQ4WyHEChXi4/Co68MF2E0 3ylM5oNv0LWWuf4uG/z7Gn4Q8yxwAAqjMrQEkj/GIhWS63MA7EGMzP8k7o1m9oSt AS48010zVDtrk+UqgwzlZ7BPQo43kWlVAvynX1fWN/iIqT/eHpYQYat/1Zj8sVAU 7cry1MaJxUrqvPo8DtBlwMSxbsZWXdYjQrVUCvoVdHU84AfuxebXavcwWB4E9AXV krg6g/VBUAbgpUcvsXlLpB0/ArOgYBDCgJmjCkcef+zhVd4shtg8M2SSSnabdAmM wV4RRY7/ =H8bT -----END PGP SIGNATURE----- --l21Zc9uzwusa2dXo--