Re: [PATCH 2/3] net: fec_mxc: Declare 'promisc' as bool

Ramon Fried
2021-10-16T18:27:10Z

On Wed, Sep 29, 2021 at 4:32 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> On Wed, Sep 29, 2021 at 01:50:45PM +0800, Bin Meng wrote:
> > priv->promisc is used as the parameter of the set_promisc() call
> > which accepts a bool type instead of char.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> > drivers/net/fec_mxc.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h
> > index 62b55ef395..133f535917 100644
> > --- a/drivers/net/fec_mxc.h
> > +++ b/drivers/net/fec_mxc.h
> > @@ -272,7 +272,7 @@ struct fec_priv {
> > struct clk clk_ref;
> > struct clk clk_ptp;
> > u32 clk_rate;
> > - char promisc;
> > + bool promisc;
> > };
> >
> > /**
> > --
> > 2.25.1
> >
>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>