From: Tom Rini <trini@konsulko.com>
To: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Cc: lukma@denx.de, sjg@chromium.org, u-boot@lists.denx.de,
joel@jms.id.au, ryan_chen@aspeedtech.com,
johnny_huang@aspeedtech.com
Subject: Re: [PATCH next v4 09/11] configs: ast2600-evb: Enable SPL FIT support
Date: Sun, 3 Oct 2021 14:40:36 -0400 [thread overview]
Message-ID: <20211003184036.GA1538@bill-the-cat> (raw)
In-Reply-To: <20210916085221.6388-10-chiawei_wang@aspeedtech.com>
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
On Thu, Sep 16, 2021 at 04:52:19PM +0800, Chia-Wei Wang wrote:
> Enable SPL FIT image load and verification support.
> The HW accelerated SHA is also available with the
> newly added support of the HACE HW hash engine.
>
> The SPL thumb build is also enabled to keep the binary
> less than 64KB to fit into the Aspeed secure boot design.
>
> Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
This causes the board to fail to build:
arm: + evb-ast2600
+(evb-ast2600) common/image-fit.c: In function 'calculate_hash':
+(evb-ast2600) common/image-fit.c:1232:46: error: 'algo' undeclared (first use in this function)
+(evb-ast2600) 1232 | hash_algo = hash_algo_lookup_by_name(algo);
+(evb-ast2600) | ^~~~
+(evb-ast2600) common/image-fit.c:1232:46: note: each undeclared identifier is reported only once for each function it appears in
+(evb-ast2600) make[2]: *** [common/image-fit.o] Error 1
+(evb-ast2600) make[1]: *** [common] Error 2
+(evb-ast2600) make: *** [sub-make] Error 2
Please rebase and repost the series, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-10-03 18:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 8:52 [PATCH next v4 00/11] aspeed: Support secure boot chain with FIT image verification Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 01/11] aspeed: ast2600: Enlarge SRAM size Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 02/11] clk: ast2600: Add YCLK control for HACE Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 03/11] crypto: aspeed: Add AST2600 HACE support Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 04/11] ARM: dts: ast2600: Add HACE to device tree Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 05/11] clk: ast2600: Add RSACLK control for ACRY Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 06/11] crypto: aspeed: Add AST2600 ACRY support Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 07/11] ARM: dts: ast2600: Add ACRY to device tree Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 08/11] ast2600: spl: Locate load buffer in DRAM space Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 09/11] configs: ast2600-evb: Enable SPL FIT support Chia-Wei Wang
2021-10-03 18:40 ` Tom Rini [this message]
2021-10-04 1:23 ` ChiaWei Wang
2021-09-16 8:52 ` [PATCH next v4 10/11] configs: aspeed: Make EXTRA_ENV_SETTINGS board specific Chia-Wei Wang
2021-09-16 8:52 ` [PATCH next v4 11/11] configs: ast2600: Boot kernel FIT in DRAM Chia-Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211003184036.GA1538@bill-the-cat \
--to=trini@konsulko.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=johnny_huang@aspeedtech.com \
--cc=lukma@denx.de \
--cc=ryan_chen@aspeedtech.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox