From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6620BC433F5 for ; Sun, 3 Oct 2021 18:40:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8D7A6126A for ; Sun, 3 Oct 2021 18:40:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C8D7A6126A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 386C283460; Sun, 3 Oct 2021 20:40:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="OsA2p3Qq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E515083460; Sun, 3 Oct 2021 20:40:44 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 24B8D83455 for ; Sun, 3 Oct 2021 20:40:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id e16so3834115qte.13 for ; Sun, 03 Oct 2021 11:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+IFJCD72Dr7GLUvZ9UChccsjLXhC5TK/JAOnOezYHLE=; b=OsA2p3Qqtq43ktYXHVTyfumWJT39e9YM9Wpi6Fds4K+2+bGKGlfNQVKWHRaEcv1Hkb 1IzC9StCwYwv1/ahSIkzFz4fi/WH/b2rwg/H1quw3JDSfvQkLXY8XobCrmoZETaKGls6 B0evCCMwx5BizKp9JAl5VGy3+RF87e3XacW68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+IFJCD72Dr7GLUvZ9UChccsjLXhC5TK/JAOnOezYHLE=; b=xe01tl5bC8tPXY+7fwAB13ujxeVpjayXccbrWc4zOhiO3UCidIcCfIxMqQrDKunGJE KtkaA/Qn/4AffW/Ta+KU9rqEFjeks64NqfATh8kwTEKCV10nUKoSkGhm9Z50xXfn8rtS PiQLu0P4/xwat5DKoieF4FGAp3MF+6SLYDNa7CQvTKGthdKDFzuNDnKjedXLKOI1R/cL 3HfBqdgng7Z1Z7E1eSha7hEH98ANrEkhtc7iIxAbUFNAuI2XNj5ugNyFtRRpn8lpHnOb ruzssSU13F/OVzimEFmi71bsUczsMv47GCP8FaH+D7+p/kJzlXFIi2O8ENlZ9AXnOJuh m4dw== X-Gm-Message-State: AOAM533A3FCZV93fZj50GmVJUgnNmIPt5ckcrULA6TmyxZ+isiWrspiX s5JRHrs8p+2sHaFCgWhQd8FeLg== X-Google-Smtp-Source: ABdhPJwkljVW6c213tlKl2vsKlRW+s4Rv10vmzF8jZW63v5Cc8JkAaqxISQdNaox6ZMS1u+ht3bEOw== X-Received: by 2002:ac8:7ed2:: with SMTP id x18mr9837394qtj.213.1633286439773; Sun, 03 Oct 2021 11:40:39 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f86e-fa98-7326-9ffc.res6.spectrum.com. [2603:6081:7b01:cbda:f86e:fa98:7326:9ffc]) by smtp.gmail.com with ESMTPSA id t8sm6522097qkt.117.2021.10.03.11.40.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Oct 2021 11:40:39 -0700 (PDT) Date: Sun, 3 Oct 2021 14:40:36 -0400 From: Tom Rini To: Chia-Wei Wang Cc: lukma@denx.de, sjg@chromium.org, u-boot@lists.denx.de, joel@jms.id.au, ryan_chen@aspeedtech.com, johnny_huang@aspeedtech.com Subject: Re: [PATCH next v4 09/11] configs: ast2600-evb: Enable SPL FIT support Message-ID: <20211003184036.GA1538@bill-the-cat> References: <20210916085221.6388-1-chiawei_wang@aspeedtech.com> <20210916085221.6388-10-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DocE+STaALJfprDB" Content-Disposition: inline In-Reply-To: <20210916085221.6388-10-chiawei_wang@aspeedtech.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 16, 2021 at 04:52:19PM +0800, Chia-Wei Wang wrote: > Enable SPL FIT image load and verification support. > The HW accelerated SHA is also available with the > newly added support of the HACE HW hash engine. >=20 > The SPL thumb build is also enabled to keep the binary > less than 64KB to fit into the Aspeed secure boot design. >=20 > Signed-off-by: Chia-Wei Wang This causes the board to fail to build: arm: + evb-ast2600 +(evb-ast2600) common/image-fit.c: In function 'calculate_hash': +(evb-ast2600) common/image-fit.c:1232:46: error: 'algo' undeclared (first = use in this function) +(evb-ast2600) 1232 | hash_algo =3D hash_algo_lookup_by_name(algo); +(evb-ast2600) | ^~~~ +(evb-ast2600) common/image-fit.c:1232:46: note: each undeclared identifier= is reported only once for each function it appears in +(evb-ast2600) make[2]: *** [common/image-fit.o] Error 1 +(evb-ast2600) make[1]: *** [common] Error 2 +(evb-ast2600) make: *** [sub-make] Error 2 Please rebase and repost the series, thanks! --=20 Tom --DocE+STaALJfprDB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFZ+RoACgkQFHw5/5Y0 tyxzrgv/Scl6addICvSUeysaqgjrtHg6PxVxA6+YtiYVyCWJ9fpg8aOhIdakeYfZ w5U4kK0FvHtm3L1i30pbiW8FZMEOXkZuv/vLdK443WLouiYE7TcTCQL3eg1IfhK8 0HArzAGhBZKD+3L8JG/6vGo17YPWww3GOBlNvYHVokywNVUrwriHUBNtppnB3YxG XDNrktRS+Dy/t3ygwxAECLgMkJJSzL3HeMmiqNKWnVoLl5QWwB4iWIMW0B8hu9/Y aI68CtezjqYCvJIRDIwWKzzveTQqiGvTIoGPbXVB922LmzZ9hs9zu64aAZrOL1lQ 5oHJyb9RWmDXkC3BEORMbVEZiPMm7qEgZWrlCEvPIqDTI9e9N9F400v133MZKcpA 5FTHMQJTAr/evuxVTRiowAwM8Bi7K5a9MLh0K9iZEoC3CAL3TrhqQ4MLJXd0kdj4 s1NfMaAWZMwu/N4f83hI26mQ0VN5WuGS1X4C1iKaAkuuAnQ5JiYD/SkVYiXLdM/m EmnQ1Tps =dRjR -----END PGP SIGNATURE----- --DocE+STaALJfprDB--