From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3622AC433F5 for ; Tue, 5 Oct 2021 15:52:47 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A7CB61166 for ; Tue, 5 Oct 2021 15:52:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3A7CB61166 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3BA4E8029E; Tue, 5 Oct 2021 17:52:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="EpvfeQ8e"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3085180202; Tue, 5 Oct 2021 17:52:42 +0200 (CEST) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5CF258029E for ; Tue, 5 Oct 2021 17:52:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id r16so19515308qtw.11 for ; Tue, 05 Oct 2021 08:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fkIc8Fsbl+Yp0wMCncT4VwjRcBPuiy5I4yx9D+ruq7k=; b=EpvfeQ8efXQhBLa/gkLrtJylrod8ETK8aosL4ezOn5FiGvZS79FREY8mWt6XCPlJuU DVqBw+K3W+f2KWvsHILj/itEkBZ/7ddkR30s8egPfDc+ZlPd/pgniC6XK1G7JxN+nZMp xLSvquhMelxG9b4BT4mnVW6iTogOGZuTuEJ2g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fkIc8Fsbl+Yp0wMCncT4VwjRcBPuiy5I4yx9D+ruq7k=; b=PXn53M2Ml9Bg2s0vmKzIgoPqpV9xBWhhdrz+RWpnr49B5m6pYlvn2zEaIHJ/VXVnqt RcabcLgxPP53F44OGF36y8PDY8T+Lz+gpXwiY5G4jNBMQV3LsBQYM6FRyvp16yBhZ2BR Hyk/IDy0rKk0yIGPJteFFX/6FHAxuoUybOwS+FeYm5KiEiPct42Wz2T8L2MKhi+URwYy /VNMKH4Abjy9Ot1//jZnn99d3eUMK46GOFSdnA9OFMhin4ByeBY/sp1tmCG7QyG0ulIf T4JVElQOKmWqEJmRl8l9B5Pq8FzXERRVUglO77ofw1x9oi1gaAVdXuowETIfsJEKWXvc Msnw== X-Gm-Message-State: AOAM533aLjPtn7YEBogFFopSYbd7PiWsB24QGxw7vKif2YiXlltUyNvS erp8bl3Uxe7Y5aadkVFhqtk4bA== X-Google-Smtp-Source: ABdhPJzopRckPJ+eEuptR2WMd5YPNTf4Dp1HZ7nuQw0QTp7W14Oat/ndg2YmKesmCspiQEuLHtKgVg== X-Received: by 2002:ac8:5e52:: with SMTP id i18mr20485004qtx.329.1633449156083; Tue, 05 Oct 2021 08:52:36 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-c976-e406-5df5-f01b.res6.spectrum.com. [2603:6081:7b01:cbda:c976:e406:5df5:f01b]) by smtp.gmail.com with ESMTPSA id u4sm759266qke.121.2021.10.05.08.52.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Oct 2021 08:52:35 -0700 (PDT) Date: Tue, 5 Oct 2021 11:52:33 -0400 From: Tom Rini To: Simon Glass Cc: Wolfgang Denk , U-Boot Mailing List , Joe Hershberger Subject: Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file Message-ID: <20211005155233.GY31748@bill-the-cat> References: <20211002003848.1803446-1-sjg@chromium.org> <20211001183842.v5.3.If789ba3e2667c46c03eda3386ca84a863baeda55@changeid> <2672911.1633349282@gemini.denx.de> <2738693.1633445755@gemini.denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HFiloqgoA10Xgb7D" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --HFiloqgoA10Xgb7D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 05, 2021 at 09:33:18AM -0600, Simon Glass wrote: > Hi Wolfgang, >=20 > On Tue, 5 Oct 2021 at 08:56, Wolfgang Denk wrote: > > > > Dear Simon, > > > > In message you wrote: > > > > > > > > Add a feature that brings in a .env file associated with the board > > > > > config, if present. To use it, create a file in a board//= env > > > > > directory called .env (or common.env if you want the same > > > > > environment for all boards). > > > > > > > > This should be no exclusive "or" here. If a common.env exists, it > > > > should be used for all boards, and if additionally one ore more > > > > .env files exist, these should ALSO be applied to the > > > > respective boards. > > > > > > Is it not enough to use #include in the main file? We have a similar > > > feature with the u-boot.dtsi files and in that case we only choose the > > > most specific. > > > > 1) This requires that the .env files are run through CPP, which is > > only added in a later patch. >=20 > OK perhaps I should just merge the patches. It is a bit artificial > having two and it seems that people agree we need the +=3D syntax. It's important to maintain bisectability, yes. But functionality should be evaluated at the end of the series, not intermediate steps. I don't have a strong opinion either way on if these two patches are merged, or not. So on a similar note, all of the feedback about the current env documentation is good and helpful, but I think a txt -> rST then enhance the rST makes the most sense so that we don't "hide" improvements within the migration. --=20 Tom --HFiloqgoA10Xgb7D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFcdL4ACgkQFHw5/5Y0 tyxqBgv+L85kEQ6XzusztUWB4dT44GfbGlqEDb3d9BUZFex0Zd3OnC8TzkoxDowI bdft4Kf91LxY0Xgmd4kNw1sJqM7CndgxjjJXuilsOdgmq5z+YVRmgvDeJH6gWCsG gXiOSsDEGuH1hRuhjR92dsAv1faUMh/DelLdo7XY99vnuSiQ0ZZFmx6DZdr2e8zN xy+icNQ4rQbOlxt901OHcD10rKUgMPjxyS7M7HRMd795vnb5wE12XEUVPaW5ufg8 a2fnMO3uFyCVQMS1ePMCiq+T28vcxQ6i4/XwxBGV4UBdspKSOVj6J6d40G3zP0EQ L+QpwlQJ7UIEb67uzAWTZGMBMX1MQqg4tlfzRwdpKFvzYXAlILaSvIPClzHNi550 akTmNK8Re/B3H2fVf04lmNkP4mdUaFsx+tDM6iRVC1tEQ8tXaNA1hWUDbdMjmTuO aE2FF9G00rrZ/GnPOAse3L5c16z0pajZkAZjpDqymPPSebLnlUOVEEKBS3/YF7rO v0KuiPQU =+k01 -----END PGP SIGNATURE----- --HFiloqgoA10Xgb7D--