From: Tom Rini <trini@konsulko.com>
To: dsankouski@gmail.com
Cc: u-boot@lists.denx.de, Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH 6/6 v3] board: samsung: add Samsung Galaxy S9/S9+(SM-G96x0) board
Date: Tue, 5 Oct 2021 12:53:26 -0400 [thread overview]
Message-ID: <20211005165326.GA29167@bill-the-cat> (raw)
In-Reply-To: <20210923185732.7679-7-dsankouski@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]
On Thu, Sep 23, 2021 at 09:57:32PM +0300, dsankouski@gmail.com wrote:
> From: Dzmitry Sankouski <dsankouski@gmail.com>
>
> Samsung S9 SM-G9600 - Snapdragon SDM845 version of the phone,
> for China \ Hong Kong markets.
> Has unlockable bootloader, unlike SM-G960U (American market version),
> which allows running u-boot as a chain-loaded bootloader.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> Changes for v2:
> - Create documentation file for SDM845 boards
> - Add starqltechn board documentation
> Changes for v3:
> - fix comment in starqltechn.c
A few things. Aside from needing to migrate a few symbols to Kconfig,
to build on current master, we need to:
> diff --git a/include/configs/starqltechn.h b/include/configs/starqltechn.h
> new file mode 100644
> index 0000000000..c9736a443b
> --- /dev/null
> +++ b/include/configs/starqltechn.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Board configuration file for Samsung S9(SM-G9600)(starqltechn)
> + *
> + * (C) Copyright 2017 Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> + */
> +
> +#ifndef __CONFIGS_STARQLTECHN_H
> +#define __CONFIGS_STARQLTECHN_H
> +
> +#include <configs/sdm845.h>
> +
> +#define CONFIG_LNX_KRNL_IMG_TEXT_OFFSET_BASE CONFIG_SYS_LOAD_ADDR
> +#define CONFIG_LINUX_KERNEL_IMAGE_HEADER
These two symbols need to be handled via Kconfig (xenguest_arm64 gets
this wrong as well, I see) as done for example on Tegra. At that point,
we can delete this file entirely and just use configs/sdm845.h.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-10-05 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 18:57 [PATCH 0/6] Add support for SDM845 based boards, and SM-G9600 dsankouski
2021-09-23 18:57 ` [PATCH 1/6 v3] serial: qcom: add support for GENI serial driver dsankouski
2021-09-23 18:57 ` [PATCH 2/6 v3] spmi: msm: add arbiter version 5 support dsankouski
2021-10-05 16:53 ` Tom Rini
2021-09-23 18:57 ` [PATCH 3/6] pinctrl: qcom: add pinctrl and gpio drivers for SDM845 SoC dsankouski
2021-09-24 10:48 ` Stephan Gerhold
2021-09-23 18:57 ` [PATCH 4/6] clocks: qcom: add clocks for SDM845 debug uart dsankouski
2021-09-23 18:57 ` [PATCH 5/6] SoC: qcom: add support for SDM845 dsankouski
2021-09-24 10:55 ` Stephan Gerhold
2021-09-23 18:57 ` [PATCH 6/6 v3] board: samsung: add Samsung Galaxy S9/S9+(SM-G96x0) board dsankouski
2021-09-24 11:02 ` Stephan Gerhold
2021-09-24 14:35 ` Dzmitry Sankouski
2021-09-24 18:50 ` Stephan Gerhold
2021-10-05 16:53 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005165326.GA29167@bill-the-cat \
--to=trini@konsulko.com \
--cc=dsankouski@gmail.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox