From: Tom Rini <trini@konsulko.com>
To: dsankouski@gmail.com
Cc: u-boot@lists.denx.de, Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH 2/6 v3] spmi: msm: add arbiter version 5 support
Date: Tue, 5 Oct 2021 12:53:31 -0400 [thread overview]
Message-ID: <20211005165331.GB29167@bill-the-cat> (raw)
In-Reply-To: <20210923185732.7679-3-dsankouski@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]
On Thu, Sep 23, 2021 at 09:57:28PM +0300, dsankouski@gmail.com wrote:
> From: Dzmitry Sankouski <dsankouski@gmail.com>
>
> Currently driver supports only version 1 and 2.
> Version 5 has slightly different registers structure
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
When building for the new platform, we get warnings such as:
In file included from /home/trini/work/u-boot/u-boot/drivers/spmi/spmi-msm.c:16:
/home/trini/work/u-boot/u-boot/drivers/spmi/spmi-msm.c: In function 'msm_spmi_probe':
/home/trini/work/u-boot/u-boot/arch/arm/include/asm/io.h:45:43: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
45 | #define __arch_getl(a) (*(volatile unsigned int *)(a))
| ^
/home/trini/work/u-boot/u-boot/arch/arm/include/asm/io.h:127:38: note: in expansion of macro '__arch_getl'
127 | #define readl(c) ({ u32 __v = __arch_getl(c); __iormb(); __v; })
| ^~~~~~~~~~~
/home/trini/work/u-boot/u-boot/drivers/spmi/spmi-msm.c:202:18: note: in expansion of macro 'readl'
202 | hw_ver = readl(config_addr + PMIC_ARB_VERSION);
| ^~~~~
/home/trini/work/u-boot/u-boot/drivers/serial/serial_msm_geni.c: In function 'qcom_geni_serial_poll_bit':
/home/trini/work/u-boot/u-boot/drivers/serial/serial_msm_geni.c:290:17: warning: implicit declaration of function 'udelay' [-Wimplicit-function-declaration]
290 | udelay(10);
| ^~~~~~
Please fix, thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-10-05 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 18:57 [PATCH 0/6] Add support for SDM845 based boards, and SM-G9600 dsankouski
2021-09-23 18:57 ` [PATCH 1/6 v3] serial: qcom: add support for GENI serial driver dsankouski
2021-09-23 18:57 ` [PATCH 2/6 v3] spmi: msm: add arbiter version 5 support dsankouski
2021-10-05 16:53 ` Tom Rini [this message]
2021-09-23 18:57 ` [PATCH 3/6] pinctrl: qcom: add pinctrl and gpio drivers for SDM845 SoC dsankouski
2021-09-24 10:48 ` Stephan Gerhold
2021-09-23 18:57 ` [PATCH 4/6] clocks: qcom: add clocks for SDM845 debug uart dsankouski
2021-09-23 18:57 ` [PATCH 5/6] SoC: qcom: add support for SDM845 dsankouski
2021-09-24 10:55 ` Stephan Gerhold
2021-09-23 18:57 ` [PATCH 6/6 v3] board: samsung: add Samsung Galaxy S9/S9+(SM-G96x0) board dsankouski
2021-09-24 11:02 ` Stephan Gerhold
2021-09-24 14:35 ` Dzmitry Sankouski
2021-09-24 18:50 ` Stephan Gerhold
2021-10-05 16:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005165331.GB29167@bill-the-cat \
--to=trini@konsulko.com \
--cc=dsankouski@gmail.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox