From: Tom Rini <trini@konsulko.com>
To: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: u-boot@lists.denx.de, etienne.carriere@linaro.org,
"Alex G ." <mr.nuke.me@gmail.com>,
"Andre Przywara" <andre.przywara@arm.com>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Christian Gmeiner" <christian.gmeiner@gmail.com>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Jens Wiklander" <jens.wiklander@linaro.org>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Masahisa Kojima" <masahisa.kojima@linaro.org>,
"Michael Walle" <michael@walle.cc>,
"Michal Simek" <michal.simek@xilinx.com>,
"Ovidiu Panait" <ovidiu.panait@windriver.com>,
"Pali Rohár" <pali@kernel.org>,
"Philipp Tomsich" <philipp.tomsich@vrull.eu>,
"Philippe Reynes" <philippe.reynes@softathome.com>,
"Roger Pau Monné" <royger@FreeBSD.org>,
"Samuel Holland" <samuel@sholland.org>,
"Sean Anderson" <seanga2@gmail.com>,
"Simon Glass" <sjg@chromium.org>, "Stefan Roese" <sr@denx.de>,
"Steffen Jaeckel" <jaeckel-floss@eyet-services.de>,
"Tero Kristo" <t-kristo@ti.com>,
"U-Boot STM32" <uboot-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH 1/2] lib: optee: remove the duplicate CONFIG_OPTEE
Date: Tue, 5 Oct 2021 18:01:41 -0400 [thread overview]
Message-ID: <20211005220141.GA31748@bill-the-cat> (raw)
In-Reply-To: <20210902115512.1.I1c6536da7609f8240549cccae2708e075dc9fcf3@changeid>
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
On Thu, Sep 02, 2021 at 11:56:16AM +0200, Patrick Delaunay wrote:
> The configuration CONFIG_OPTEE is defined 2 times:
> 1- in lib/optee/Kconfig for support of OPTEE images loaded by bootm command
> 2- in drivers/tee/optee/Kconfig for support of OP-TEE driver.
>
> It is abnormal to have the same CONFIG define for 2 purpose;
> and it is difficult to managed correctly their dependencies.
>
> Moreover CONFIG_SPL_OPTEE is defined in common/spl/Kconfig
> to manage OPTEE image load in SPL.
>
> This definition causes an issue with the macro CONFIG_IS_ENABLED(OPTEE)
> to test the availability of the OP-TEE driver.
>
> This patch cleans the configuration dependency with:
> - CONFIG_OPTEE_IMAGE (renamed) => support of OP-TEE image in U-Boot
> - CONFIG_SPL_OPTEE_IMAGE (renamed) => support of OP-TEE image in SPL
> - CONFIG_OPTEE (same) => support of OP-TEE driver in U-Boot
> - CONFIG_OPTEE_LIB (new) => support of OP-TEE library
>
> After this patch, the macro have the correct behavior:
> - CONFIG_IS_ENABLED(OPTEE_IMAGE) => Load of OP-TEE image is supported
> - CONFIG_IS_ENABLED(OPTEE) => OP-TEE driver is supported
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-10-05 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 9:56 [PATCH 1/2] lib: optee: remove the duplicate CONFIG_OPTEE Patrick Delaunay
2021-09-02 9:56 ` [PATCH 2/2] tee: add a stub for tee_find_device Patrick Delaunay
2021-09-03 10:08 ` Etienne Carriere
2021-09-13 19:10 ` Jens Wiklander
2021-10-05 22:01 ` Tom Rini
2021-09-03 16:43 ` [PATCH 1/2] lib: optee: remove the duplicate CONFIG_OPTEE Alex G.
2021-09-04 8:31 ` Etienne Carriere
2021-09-06 16:53 ` Patrick DELAUNAY
2021-09-06 22:39 ` Alex G.
2021-09-07 18:46 ` Alex G.
2021-10-05 22:01 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005220141.GA31748@bill-the-cat \
--to=trini@konsulko.com \
--cc=andre.przywara@arm.com \
--cc=bmeng.cn@gmail.com \
--cc=bryan.odonoghue@linaro.org \
--cc=christian.gmeiner@gmail.com \
--cc=etienne.carriere@linaro.org \
--cc=jaeckel-floss@eyet-services.de \
--cc=jens.wiklander@linaro.org \
--cc=kever.yang@rock-chips.com \
--cc=masahisa.kojima@linaro.org \
--cc=michael@walle.cc \
--cc=michal.simek@xilinx.com \
--cc=mr.nuke.me@gmail.com \
--cc=ovidiu.panait@windriver.com \
--cc=pali@kernel.org \
--cc=patrick.delaunay@foss.st.com \
--cc=philipp.tomsich@vrull.eu \
--cc=philippe.reynes@softathome.com \
--cc=royger@FreeBSD.org \
--cc=samuel@sholland.org \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=t-kristo@ti.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox