Re: [PATCH v5 16/29] efi: Correct dependency on FIT_SIGNATURE

Tom Rini
2021-10-09T01:44:59Z

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

On Sat, Sep 25, 2021 at 07:43:29PM -0600, Simon Glass wrote:

> At present EFI_SECURE BOOT selects RSA but does not necessarily enable
> FIT_SIGNATURE. Mostly this is fine, but a few boards do not enable it,
> so U-Boot tries to do RSA verification when loading FIT images, but it
> is not enabled.
>
> This worked because the condition for checking the RSA signature is
> wrong in the fit_image_verify_with_data() function. In order to fix it
> we need to fix this dependency. Make sure that FIT_SIGNATURE is enabled
> so that RSA can be used.
>
> It might be better to avoid using 'select' in this situation.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]