From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3ECC433F5 for ; Mon, 11 Oct 2021 00:29:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B18D60F3A for ; Mon, 11 Oct 2021 00:29:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7B18D60F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A958983475; Mon, 11 Oct 2021 02:29:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="sayExXoZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1013E8354E; Mon, 11 Oct 2021 02:29:22 +0200 (CEST) Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 57384832DE for ; Mon, 11 Oct 2021 02:29:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x536.google.com with SMTP id g184so9181989pgc.6 for ; Sun, 10 Oct 2021 17:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=BIM9y6V5dXIetJC4+4dPvJ/yiA+PblwJJ+OsKwzIQ5I=; b=sayExXoZ/h6mXJ9t4hzv0SgmIIdBRiXP+L7mL85VTbIWSPWjEkCyyNr/Kus1lvFdrd nqRNPE+X6vz81BHeCwFxR4TbHRLNg9mlzBl3OVyjzPYdkWLJU5f4mkQHNP7v5MnbdCg4 +tEoLt1JsyZKHZctgd4fPFsISVDSxwdhcYJME5rJ73doBE8PDclkiA4JiDqPQPy9o01J SSAFy6qR5IrEbslVtSZm5jBE9E7XLsZDWF0RxGfOjTMwXjSTWiPNyVZFbn5a06uj+g4n HR4Nz9ZbXRbQO3t1Z879nR592S83LcKLOAz26Zpb9+wmTJV+lvAq8W9w0njK0Q4/iRGM 5Z/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=BIM9y6V5dXIetJC4+4dPvJ/yiA+PblwJJ+OsKwzIQ5I=; b=KbKyMQ4lsfj8JRj/cmsgyESmEtboYPu37fPqel0NlXJmR1brwrNu6xzlcBjs9EFlwx lK8ndsCauPqJe+EHAGBl2e6O3Zr8Zz9b4rrcE/ilootsC8a2YwL8TjWw2ObI2+sCxQCQ pNz+0C1kYQnZIJ89dRAq+PLRAfZecflVDgXOrgNAPoAX8YA17EG1Px6+FXFuk6dC6lYb sq3sON7ba8nYnbPbkggfDlxyYuCzy7nRy40vKSWB/zAqfATrQ1iHbHxwzRGdTTsid0QS YiFPGFVJ/LDCSZifnizBIgvbsvShKmnnK2KA5ZsaRmsjCY2X1mLj+Xn+IlsLwvTeAnfb XS1w== X-Gm-Message-State: AOAM530VjyBquho9cCkM4SPZFkVNQnglqLcW/DI0zNUlANMG5mfkYcWR iZCDoL/Tz/7SwEnptihmczkyOQ== X-Google-Smtp-Source: ABdhPJxmOCysPpHB9eBcjTjfzNwnzPj5FRFiJFrgB5sA2kiu2I58JlBkLZigaBgUpGqeZYFTrpJNQw== X-Received: by 2002:a63:4f56:: with SMTP id p22mr15851097pgl.134.1633912155414; Sun, 10 Oct 2021 17:29:15 -0700 (PDT) Received: from laputa (122-100-26-39m5.mineo.jp. [122.100.26.39]) by smtp.gmail.com with ESMTPSA id o14sm5673671pfh.145.2021.10.10.17.29.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Oct 2021 17:29:14 -0700 (PDT) Date: Mon, 11 Oct 2021 09:29:08 +0900 From: AKASHI Takahiro To: Ilias Apalodimas Cc: Simon Glass , Heinrich Schuchardt , Alex Graf , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List Subject: Re: [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options"" Message-ID: <20211011002908.GA44356@laputa> Mail-Followup-To: AKASHI Takahiro , Ilias Apalodimas , Simon Glass , Heinrich Schuchardt , Alex Graf , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List References: <20211007062340.72207-1-takahiro.akashi@linaro.org> <20211007062340.72207-2-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Oct 08, 2021 at 10:11:59PM +0300, Ilias Apalodimas wrote: > Hi Simon, > > On Fri, Oct 08, 2021 at 09:38:11AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro wrote: > > > > > > This reverts commit d428e81266a59974ade74c1ba019af39f23304ab. > > > We have agreed with removing dtb-related stuff from mkeficapsule > > > command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move > > > signature from DTB to .rodata"") was applied. > > > > Can you please explain why this is being removed? How is the public > > key to be communicated? > > Via the script that Akashi-san is adding in this patch series. Yeah, please see my patch#4 for fdtsig.sh. The reason why I think we should remove the feature from mkeficapsule command is partly because we can do the same task by using *existing* fdt tools and partly because having two totally-independent functionality (one for a capsule binary and one for fdt) in a single tool seems confusing. > > > > Please can you also copy me on future related patches? (thank for you > > for the private email alerting me) > > > > What does "We have agreed" mean? > > This has nothing to do with the public key. This is only changing the tool > we used to include the key in the DTB. It is the same patch I mentioned you > should never have reverted in the first place on your pull request, but since > that happened very late in the release cycle we said we would re-apply it after > the release. Indeed. -Takahiro Akashi > > > > > > > > Signed-off-by: AKASHI Takahiro > > > --- > > > tools/mkeficapsule.c | 229 ++----------------------------------------- > > > 1 file changed, 7 insertions(+), 222 deletions(-) > > > > > > > Regards, > > Simon > > It was my patch to begin with so I am not really sure my reviewed tag has > any value, but FWIW > > Reviewed-by: Ilias Apalodimas