Re: [RFC 06/22] sata: call device_probe() after scanning

Simon Glass
2021-10-10T14:15:36Z

Hi Takahiro,

On Thu, 30 Sept 2021 at 23:03, AKASHI Takahiro
<takahiro.akashi@linaro.org> wrote:
>
> Every time a sata bus/port is scanned and a new device is detected,
> we want to call device_probe() as it will give us a chance to run additional
> post-processings for some purposes.
>
> In particular, support for creating partitions on a device will be added.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> drivers/ata/dwc_ahsata.c | 10 ++++++++++
> drivers/ata/fsl_sata.c | 11 +++++++++++
> drivers/ata/sata_mv.c | 9 +++++++++
> drivers/ata/sata_sil.c | 12 ++++++++++++
> 4 files changed, 42 insertions(+)
>
> diff --git a/drivers/ata/dwc_ahsata.c b/drivers/ata/dwc_ahsata.c
> index 6d42548087b3..6a51c70d1170 100644
> --- a/drivers/ata/dwc_ahsata.c
> +++ b/drivers/ata/dwc_ahsata.c
> @@ -1026,6 +1026,16 @@ int dwc_ahsata_scan(struct udevice *dev)
> return ret;
> }
>
> + ret = device_probe(bdev);
> + if (ret < 0) {
> + debug("Can't probe\n");
> + /* TODO: undo create */
> +
> + device_unbind(bdev);

It looks like this one has the wrong variable name.

[..]

Regards,
Simon