From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B24F4C433F5 for ; Tue, 12 Oct 2021 01:15:19 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB45660F38 for ; Tue, 12 Oct 2021 01:15:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BB45660F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B5EC38331C; Tue, 12 Oct 2021 03:15:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="LJ+t3Nur"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 209C58341D; Tue, 12 Oct 2021 03:15:14 +0200 (CEST) Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D85F815CE for ; Tue, 12 Oct 2021 03:15:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x52f.google.com with SMTP id 133so12346650pgb.1 for ; Mon, 11 Oct 2021 18:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=jhpSJ3IkZTm85vR5rTmKcbT0TO1tjamd2VdtFLN3V10=; b=LJ+t3NurpjRrBeBm2IKi/Hc5t5qhN/g5PR8wHXsKlxZ42sg024SmHkBeBQPnzrJ4d2 arIXJqMfD7ciaBa0tdYJa4+Hqu3+XevLA3YamzNrKY0Zd4Ru6pvNIY3QgTiXEUsSBO5j hB8JUZOpmImKfJeSFYPfs2SLNq+JkrypLBeOu0AZXpdG3TPwgfWBSIzqWm1XeR7c7eBT GN/cdfkFXTKx9XJ66Jv72AramiyFv9RCMx6QwI/p0AlFE9HaPmTeD8YWNcVsovkDKnfR bY6AFI7JRf2QkY/oSnU76f0QyiMvLNHY04cEeb9w606+esXOdFfPNTXEczMAF/iR4eTM zKeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=jhpSJ3IkZTm85vR5rTmKcbT0TO1tjamd2VdtFLN3V10=; b=WBLAP6S9sfVB1uk7rqACDamHRMsWLLqsaoUkpl9dyItBpbCJ1mfMbkrzBMj7jG71lQ 83vVnu3BKEssv6haCn+AFcn59KUacuNel/VMuIf6AHA2XNX9zeEoqA16K1PIXfcnfihe SG6cq4K2Ljj0AsjY1uehpb+BJDlQ+OsH859y5vKyn0SayZttDAJcggr0kfnLEXLC774K bayqFXmuOEzJbJWUomYzGoxf2+L0MV2jDnb9M9X4YlD7HHUsY67DCIM2NLVVMoV4wsoH H2WslM2r5qvDuQ8EsD00sQsXI8D4tIyZoZasn9opQD/JSUfKQ47zoGC+WT30t/BHhjp/ vDyA== X-Gm-Message-State: AOAM533reiFsvBeJvRNVpuP0t6nfQLl7KNS+3lojIz3EOIx8v6cAqIFc bfIIKPwCa9JftfOT4+nZ+DbkwA== X-Google-Smtp-Source: ABdhPJwC4S9ioks9A3BeKr69nvOYlR5chuvJ1PgIpeqtqYfkySATk3g3yfePVJ5rvNkTQLga9+hp5w== X-Received: by 2002:a62:6d07:0:b0:446:c141:7d2d with SMTP id i7-20020a626d07000000b00446c1417d2dmr28568587pfc.28.1634001308024; Mon, 11 Oct 2021 18:15:08 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:dbc:a6fe:8374:7fdb]) by smtp.gmail.com with ESMTPSA id w8sm9071598pfd.4.2021.10.11.18.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 18:15:07 -0700 (PDT) Date: Tue, 12 Oct 2021 10:15:03 +0900 From: AKASHI Takahiro To: Simon Glass Cc: Ilias Apalodimas , Heinrich Schuchardt , Alex Graf , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List Subject: Re: [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options"" Message-ID: <20211012011503.GB38222@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , Ilias Apalodimas , Heinrich Schuchardt , Alex Graf , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List References: <20211007062340.72207-1-takahiro.akashi@linaro.org> <20211007062340.72207-2-takahiro.akashi@linaro.org> <20211011002908.GA44356@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Simon, On Mon, Oct 11, 2021 at 08:54:10AM -0600, Simon Glass wrote: > Hi Takahiro, Ilias, > > On Sun, 10 Oct 2021 at 18:29, AKASHI Takahiro > wrote: > > > > On Fri, Oct 08, 2021 at 10:11:59PM +0300, Ilias Apalodimas wrote: > > > Hi Simon, > > > > > > On Fri, Oct 08, 2021 at 09:38:11AM -0600, Simon Glass wrote: > > > > Hi Takahiro, > > > > > > > > On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro wrote: > > > > > > > > > > This reverts commit d428e81266a59974ade74c1ba019af39f23304ab. > > > > > We have agreed with removing dtb-related stuff from mkeficapsule > > > > > command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move > > > > > signature from DTB to .rodata"") was applied. > > > > > > > > Can you please explain why this is being removed? How is the public > > > > key to be communicated? > > > > > > Via the script that Akashi-san is adding in this patch series. > > > > Yeah, please see my patch#4 for fdtsig.sh. > > OK I see. I don't think I was copied on that. I replied on the patch. In my initial submission, there were some accidentally-duplicated patches that would have caused some confusion. > Is there a tree somewhere with all the patches and docs so I can take a look? Please take a look at: https://git.linaro.org/people/takahiro.akashi/u-boot.git efi/dm_disk -Takahiro Akashi > Regards, > Simon > > > > > The reason why I think we should remove the feature from mkeficapsule > > command is partly because we can do the same task by using *existing* > > fdt tools and partly because having two totally-independent functionality > > (one for a capsule binary and one for fdt) in a single tool seems confusing. > > > > > > > > > > Please can you also copy me on future related patches? (thank for you > > > > for the private email alerting me) > > > > > > > > What does "We have agreed" mean? > > > > > > This has nothing to do with the public key. This is only changing the tool > > > we used to include the key in the DTB. It is the same patch I mentioned you > > > should never have reverted in the first place on your pull request, but since > > > that happened very late in the release cycle we said we would re-apply it after > > > the release. > > > > Indeed. > > > > -Takahiro Akashi > > > > > > > > > > > > > > > > > > Signed-off-by: AKASHI Takahiro > > > > > --- > > > > > tools/mkeficapsule.c | 229 ++----------------------------------------- > > > > > 1 file changed, 7 insertions(+), 222 deletions(-) > > > > > > > > > > > > > Regards, > > > > Simon > > > > > > It was my patch to begin with so I am not really sure my reviewed tag has > > > any value, but FWIW > > > > > > Reviewed-by: Ilias Apalodimas