From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A42DC433EF for ; Tue, 12 Oct 2021 11:05:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 129D061050 for ; Tue, 12 Oct 2021 11:05:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 129D061050 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 60CD583729; Tue, 12 Oct 2021 13:05:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="XV+Epi0M"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B88BB83728; Tue, 12 Oct 2021 13:05:17 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 141A583728 for ; Tue, 12 Oct 2021 13:05:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id D0BD461076; Tue, 12 Oct 2021 11:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634036710; bh=azufc8ZCrr6nbVgqz/ls9p9f0rn0Xxhiza+2sgwUtto=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XV+Epi0M+5BY8dVo7OFtEs5awA0ZU8P/I3pPqIIa5t0wxG2y8DqAvhbogNElN5nw6 IjV1+0j4Acgwa6Ifx5YoN4svzJ0bnRKcMUt9LvpJT0THc/OAdpSQE0uAK9hIuhyeVr hX37IZn4jPDmI+ueaTL+yfxsYqaDQBM8RjcplYyE6uMvTna/BrPy7IqFXVXTj0VFw1 X+Ji9FGP+rKW/upqPoJ+pHn/OpK1nh8/SZlq6UD8CCOqsJlSN6YtLciDnrafLX7leM LGlLb3FDOoOWynf+yyiE7o2hrQ2IYkaOo1qsJwkuyZyyFg3BKUK1QndmhRhtSoqicX D0yI27Mvxh2dw== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Simon Glass , Tom Rini Cc: U-Boot Mailing List , =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH 04/10] env: Don't match empty variable name in env_match() Date: Tue, 12 Oct 2021 13:04:55 +0200 Message-Id: <20211012110501.6118-5-kabel@kernel.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211012110501.6118-1-kabel@kernel.org> References: <20211012110501.6118-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean From: Marek Behún Do we really allow zero-length variable name? I guess not. Signed-off-by: Marek Behún --- cmd/nvedit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/nvedit.c b/cmd/nvedit.c index 742e0924af..e2e8a38b5d 100644 --- a/cmd/nvedit.c +++ b/cmd/nvedit.c @@ -708,7 +708,7 @@ char *from_env(const char *envvar) static int env_match(uchar *s1, int i2) { - if (s1 == NULL) + if (s1 == NULL || *s1 == '\0') return -1; while (*s1 == env_get_char(i2++)) -- 2.32.0