From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 498DCC433EF for ; Wed, 13 Oct 2021 13:12:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D66F603E7 for ; Wed, 13 Oct 2021 13:12:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D66F603E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 05E26835A2; Wed, 13 Oct 2021 15:12:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="C9SeyXhk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 10F1A835A2; Wed, 13 Oct 2021 15:12:18 +0200 (CEST) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7C5BA83599 for ; Wed, 13 Oct 2021 15:12:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id r1so2393435qta.12 for ; Wed, 13 Oct 2021 06:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fk3t+/37qo1/sH2PvLXQxavEntlZjBgx3T5+5BXQ+ck=; b=C9SeyXhkOJjJ4OMJLM+eXkhSiXJANgjTmVGgtQTSXr5XpKCc1ufE7Hi/0hesAsJW0f hvFEUpwUWjp9SbxD6b7CLxBVeYWC9Z/G66qJzoQl81zj9O1gPg5uYFmRJXe+TNjKxur+ 2aXC8cK+LYpDHIRKYarYqM+aCgjyjIpNyoHEA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fk3t+/37qo1/sH2PvLXQxavEntlZjBgx3T5+5BXQ+ck=; b=aaVMHrMIxVIhSCkDfoJvx0zo/aVNpUXlnCgUhNK7dUdl4DfZn6yzLpNoGXZZ4L3aPk ItVqbce5Z3WlXskI6HkeMAb2c40bCAAkkLue9sIUl6Ovn7bIOIvMB6FvIBpMv+TEmhuL o5ZvGDT/VdoH8RrKvrcxIbAunszMqVSrjo2uDxL4xL+/5x9iQjMOdKCm1KbLx15bzEOy hAfCjYaNa4GwDYxw1k3X8eT3vaAW3fH01IGjYRxAeVbFkGTePNPDdKuNQZZAUOAlVYdN qbS5wH9xYJrjq+cQvcyHB4l63WWdkq6l2D8jWsMMf6iqoryEf8mstckds+UPlAfFDQUB wviA== X-Gm-Message-State: AOAM5332qsVzJxfb4Apk36Zy6IGBcrTXPOinJ2EyYGBYGKlDSF4SJGxL weqG9TtSV9zK23c8L+m2rUKZog== X-Google-Smtp-Source: ABdhPJwXgUgeoxvyNpfaf9AN/f3GbpVRmT4tZBkTjz+/aMhqMPcufZ92IejVQ0n0p3FTnkpr4M73mA== X-Received: by 2002:a05:622a:1209:: with SMTP id y9mr15674421qtx.13.1634130733205; Wed, 13 Oct 2021 06:12:13 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-e98d-c49f-f596-1fb5.res6.spectrum.com. [2603:6081:7b01:cbda:e98d:c49f:f596:1fb5]) by smtp.gmail.com with ESMTPSA id i14sm7268750qka.19.2021.10.13.06.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 06:12:12 -0700 (PDT) Date: Wed, 13 Oct 2021 09:12:10 -0400 From: Tom Rini To: "Peng Fan (OSS)" Cc: sjg@chromium.org, u-boot@lists.denx.de, Peng Fan Subject: Re: [PATCH] scripts: pylibfdt: add a new include path Message-ID: <20211013131210.GL7964@bill-the-cat> References: <20211013093952.16466-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oeBCTU8dS3Egdm61" Content-Disposition: inline In-Reply-To: <20211013093952.16466-1-peng.fan@oss.nxp.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --oeBCTU8dS3Egdm61 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 13, 2021 at 05:39:52PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan >=20 > Opensuse python headers are under: > =3D>ls /usr/include/python > python@ python2.7/ python3.6m/ python3.8/ python3.9/ >=20 > So add '-I/usr/include/python' to fix build on Opensuse Host. > It should not hurt with other Host >=20 > Signed-off-by: Peng Fan > --- > scripts/dtc/pylibfdt/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/scripts/dtc/pylibfdt/Makefile b/scripts/dtc/pylibfdt/Makefile > index 493995e303..698790a1a0 100644 > --- a/scripts/dtc/pylibfdt/Makefile > +++ b/scripts/dtc/pylibfdt/Makefile > @@ -18,7 +18,7 @@ quiet_cmd_pymod =3D PYMOD $@ > CC=3D"$(HOSTCC)" LDSHARED=3D"$(HOSTCC) -shared " \ > LDFLAGS=3D"$(HOSTLDFLAGS)" \ > VERSION=3D"u-boot-$(UBOOTVERSION)" \ > - CPPFLAGS=3D"$(HOSTCFLAGS) -I$(LIBFDT_srcdir)" OBJDIR=3D$(obj) \ > + CPPFLAGS=3D"$(HOSTCFLAGS) -I$(LIBFDT_srcdir) -I/usr/include/python" OB= JDIR=3D$(obj) \ > SOURCES=3D"$(PYLIBFDT_srcs)" \ > SWIG_OPTS=3D"-I$(LIBFDT_srcdir) -I$(LIBFDT_srcdir)/.." \ > $(PYTHON3) $< --quiet build_ext --inplace We should probably, somewhere, be using something like "pkg-config --cflags python3" to find out where to include. Hard-coded /usr paths are bad for environments like OpenEmbedded and generally non-portable. --=20 Tom --oeBCTU8dS3Egdm61 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFm2ycACgkQFHw5/5Y0 tyy2xQv+NBqWIqkTVttTPAqsA4vRMvfhqhpNjDqCo7OReioeQqlJ8TTsdldOI8vk DAnEQG4JAokNJ8sPVEjpM5eq+9XQ1ibERGytcF+poS7UGJ4Z3imX1vvO5zy4sKSN pc8tm54G1+GA0C/TRb+pudXT+GruiGBNKcnvP5tVIgGRJwJqP3I/ihvokocMHgjK PoZxoDRX4VL7v+bPXvvlcuUmlWWmKDrVekBehXtuQtEz1AJnmTTl7/bM5a3OJcyA G4nhkOuSkEK4eMkuJqRPutveNW5Bldii/oBS8USNg+2aEg5PX0F1g8djHhKuFebS niR+enjxEXiSN90DjGOgcrWobA3gd6FWx1mo7P5lV7j5TqE+MYpcNN/22JBf80dS c3fJfTsPCYn6jygsW+uUsiGwapTCk3+pGDkCE5oXU/2Nst86AdtNyhaWolrAmvU9 buCDniFKDdmvngz2r9YKUxPAiQIcbrAYPXVjoBqgzmPVQCdoTj2mc1FhVlolnei+ VgPwo2WK =6NFB -----END PGP SIGNATURE----- --oeBCTU8dS3Egdm61--