From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00626C4332F for ; Wed, 13 Oct 2021 14:16:36 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56598610F8 for ; Wed, 13 Oct 2021 14:16:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 56598610F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ABB6D835A2; Wed, 13 Oct 2021 16:16:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="nQvUcDek"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D01B883172; Wed, 13 Oct 2021 16:16:24 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 57E7483569 for ; Wed, 13 Oct 2021 16:16:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id 77so2304586qkh.6 for ; Wed, 13 Oct 2021 07:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xvFVe+dtzqc0CYvfnCazJbcqn+tqmeYUz98kp6nC6Ns=; b=nQvUcDekWdAyWkvns2sqlhZxRwjwkUrGejOT7IA/A0bFeYFWXDaXAkoJ7Cg9qjtusI Jg2swpQLA9rFKNy6tiUfvFuhmr+Nz+ZCtGso0qQhRYyVgzjx8kDCkvJW612MlUeTMExG mpbroF5B/FmXy0hEW0Lv8GTCFiFL8u7BKJY2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xvFVe+dtzqc0CYvfnCazJbcqn+tqmeYUz98kp6nC6Ns=; b=FC7iV+aR/taUFW6bAJ5MkV7MvZhw+AiJDfdep1KUHEFsd+zIikpg5NJ5veyau+/Tdl o6XilHJ/SGv5sor5P943Ean48zRAtJCWyFzas0ayhGvyq2c5ix1Boo4EyJe9EZE/0Dcc 91Km+Mt6OQ4KhrKPOefO+V53/zrpPw311j6o+F9ox5LM9zpvpMuzGCuHureOS1LqIeqC Bpf5BoxLxeFhXJQx1YOhCSatlECSRMAbaRzbABEjtvch2gyWK0XDi4A4wee21FDgUVsv SIo6O1aRLqUfTgp53oBnKKy9H7U3XC7fjJO10DL9LcmPyPYNCLd5cb9G42q78tGDedXG He+g== X-Gm-Message-State: AOAM533uKZQNdoXv5Ufq0/BHM8CTMmiDMG9G9/IRnmcJXq14DV0GrOzQ Zg3H891UnQzHrRFVO2hHGor4iA== X-Google-Smtp-Source: ABdhPJxgivKi5v/GLDoIgBM4vJuTai89YZ6LJeSJDcnBrjvmJQllsrjzzFZhRjPFTY9G02AOyPZt9g== X-Received: by 2002:a37:6458:: with SMTP id y85mr21611072qkb.492.1634134579278; Wed, 13 Oct 2021 07:16:19 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-e98d-c49f-f596-1fb5.res6.spectrum.com. [2603:6081:7b01:cbda:e98d:c49f:f596:1fb5]) by smtp.gmail.com with ESMTPSA id o2sm1634427qtm.0.2021.10.13.07.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 07:16:18 -0700 (PDT) Date: Wed, 13 Oct 2021 10:16:16 -0400 From: Tom Rini To: Matthias Schiffer Cc: u-boot@lists.denx.de, Sean Anderson Subject: Re: [PATCH] fastboot: fix partition name truncation in environment lookup Message-ID: <20211013141616.GP7964@bill-the-cat> References: <20210730122354.6281-1-matthias.schiffer@ew.tq-group.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Vl2Kt1BVI5g15hg1" Content-Disposition: inline In-Reply-To: <20210730122354.6281-1-matthias.schiffer@ew.tq-group.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Vl2Kt1BVI5g15hg1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 30, 2021 at 02:23:54PM +0200, Matthias Schiffer wrote: > strlcat() need to be passed the full buffer length. The incorrect call > caused truncation of partition names for fastboot_raw_partition_... and > fastboot_partition_alias_... env lookup to much less than PART_NAME_LEN. >=20 > Fixes: 69a752983171 ("fastboot: Fix possible buffer overrun") > Signed-off-by: Matthias Schiffer > Reviewed-by: Sean Anderson Applied to u-boot/master, thanks! --=20 Tom --Vl2Kt1BVI5g15hg1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFm6jAACgkQFHw5/5Y0 tyzDBgwAgSbnJpYmt+Cc/34VC5ZagLG2Pk53VxXpBAoEZu5Lskb6lWIkmJLs2099 VbDA9IVB9Bacxi5hPQgnynAjrKz7ZdAmrH7/NdG8j/Xm27+fWEfrIuUzPaadV1Hj 7HxYS9pjRAZFGKWCTcTjhA54ploD8gdyAT5YyXAr1RCkgh8P4NuLkRzpyXU5qI+9 Jfd817evvy33vRqUQ+LqHYWAVTzet+l7td/u7I/T8OU7DUHu2Ye5Swfb8ZJDwQjw gBb22oH/5PB2AIku3G0hzTrjCxKgN1Inngo3rMMAGKX4jeW1b69NEWBHE+U2j3Zx XMvearCAhc2oTlKb60u9356yXDjUARpF28gLgOBrlqTXCbqkeXHBfUEcEL9RRUsk NOIXluo6el5T8NezafknTwKCpglNA+Hjq5tr9QHAkdEuTk7u3fMV4G78prmxfEM6 a1fkqZsAVaj263s0RAEFw8mZLbuBjDAmsfrB6m0cbL+pbduC/FvNPe1Z6d+4XFR9 jNYApJXC =+5dS -----END PGP SIGNATURE----- --Vl2Kt1BVI5g15hg1--