From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD34C433F5 for ; Wed, 13 Oct 2021 15:48:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33C1960E97 for ; Wed, 13 Oct 2021 15:48:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 33C1960E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1723E8360D; Wed, 13 Oct 2021 17:47:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="HM1jRxEK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D305B835C3; Wed, 13 Oct 2021 17:46:24 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 66E82835A2 for ; Wed, 13 Oct 2021 17:46:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 235DF610CF; Wed, 13 Oct 2021 15:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634139974; bh=rrDvWff28Y1eGGSEfVFcABmkMGKt07cR1qsNDhsjb6E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HM1jRxEKtrqi5zZAJmn4AQd91ExJ5x3G63NK3vhGakTrnWOYcjseRjMMCYLnkAHU+ SkB8qbnyHfIDGlvGtIqESMidevDpc9t95zHcM3HRWKFfPGGATSOW2z+1bWnmZ92hMw 71EUiUswImLDmJ7kmI3onILQycP6K/rBGYM8VMsuUJ4LZ7fge09xFFzwlhFiMzTVqa xa9VQtwackC0bbxP1jDFeG+dghYONkvzdLuQW9mJ27+94xRQHlL9P04IAghnniyGw6 ra12eST64iDx0vIY9I7H1n+m8e6R4KF5Tsm15gJQFrXjOSQ0we9MmJ7ebvOG6s7c5r 99r8dR12dCwgw== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Simon Glass , Tom Rini Cc: U-Boot Mailing List , =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH v2 10/13] env: Use better name for variable in env_get_f() Date: Wed, 13 Oct 2021 17:45:54 +0200 Message-Id: <20211013154557.28479-11-kabel@kernel.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211013154557.28479-1-kabel@kernel.org> References: <20211013154557.28479-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean From: Marek Behún The `nxt` variable actually points to the terminating null-byte of the current env var, and the next env var is at `nxt + 1`, not `nxt`. So a better name for this variable is `end`. Signed-off-by: Marek Behún --- cmd/nvedit.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/nvedit.c b/cmd/nvedit.c index 6eabd51209..08288fad10 100644 --- a/cmd/nvedit.c +++ b/cmd/nvedit.c @@ -724,7 +724,7 @@ static const char *matching_name_get_value(const char *p, const char *name) */ int env_get_f(const char *name, char *buf, unsigned len) { - const char *env, *p, *nxt; + const char *env, *p, *end; if (name == NULL || *name == '\0') return -1; @@ -734,12 +734,12 @@ int env_get_f(const char *name, char *buf, unsigned len) else env = (const char *)gd->env_addr; - for (p = env; *p != '\0'; p = nxt + 1) { + for (p = env; *p != '\0'; p = end + 1) { const char *value; int n; - for (nxt = p; *nxt != '\0'; ++nxt) - if (nxt - env >= CONFIG_ENV_SIZE) + for (end = p; *end != '\0'; ++end) + if (end - env >= CONFIG_ENV_SIZE) return -1; value = matching_name_get_value(p, name); -- 2.32.0