From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1262DC433F5 for ; Wed, 13 Oct 2021 17:58:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 538AA604DC for ; Wed, 13 Oct 2021 17:58:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 538AA604DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A2004835CE; Wed, 13 Oct 2021 19:58:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MsMJEXBv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DBCE6835DF; Wed, 13 Oct 2021 19:58:15 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0DD2083172 for ; Wed, 13 Oct 2021 19:58:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id t2so3363237qtx.8 for ; Wed, 13 Oct 2021 10:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=n8gsboJFqRFnYdGp/zOoJIWs4uLoS+RSV9hBcOzoCbE=; b=MsMJEXBvjAw6V8++ZOoEwitnEfNRapGUD+5jJz2oi4bpVVGWYBVbA/DohGxRoPY+du llXPHhmQUhjemsSMyjOdnr/oUxHYTeqfRwEl1MEKSvFufuy33Lu4yhEL0TtY+5S2XUnK YPftbdeRNsqrhOUlc/VcZHr6f37K1RdCAaXs8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=n8gsboJFqRFnYdGp/zOoJIWs4uLoS+RSV9hBcOzoCbE=; b=GxI0Lqrl+Ytn3zhra+OVqaOaMoLauqhwyOTrXpyqmk1LvTA98f+A7RAEWzHcIlBmbo el5Vewn/n6UAU1MECzFKkxNiOfD/Di6QsFxhe/FCNktxl85EgUFwezgm3JRY4QVTEXk1 +VD6l2YJM/odL+9D9f2/R93/BB1G82gCKcXrGAqUT7yyX6IA71D+oewx6Gadwyt7deLP wSsBXMUh5guwmGpGoD3qsVXSz6Plp1J2Ei4n7EjQsgKTVAbbOw8kkgKfW4gJEjRK47z2 q7MQGaYqFA0Km9c6tB//v88DqhprUiAAREgyaajNM7BtUzbawSvAVmrXaOlZLutrv2js iwPg== X-Gm-Message-State: AOAM532fEo4Iw3gV5Z3EyBPdWuC2iiojEeq5W88eGsMQbanYAEnrBUWO RbWRdLgAHpeGuVpkU0gCN6gofg== X-Google-Smtp-Source: ABdhPJzPMQhzvR2BWj77OuJwsJJuH7/Fru6hJsjlWS783PTpsmCpFId2Ozj7YQucb7BjP/8ctati8Q== X-Received: by 2002:ac8:58d3:: with SMTP id u19mr878247qta.29.1634147890774; Wed, 13 Oct 2021 10:58:10 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-e98d-c49f-f596-1fb5.res6.spectrum.com. [2603:6081:7b01:cbda:e98d:c49f:f596:1fb5]) by smtp.gmail.com with ESMTPSA id t11sm121398qkm.92.2021.10.13.10.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 10:58:09 -0700 (PDT) Date: Wed, 13 Oct 2021 13:58:07 -0400 From: Tom Rini To: Thomas Fitzsimmons Cc: Simon Glass , Ilias Apalodimas , Rick Chen , Leo , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , Green Wan , Sean Anderson , Lukas Auer , Brad Kim , Zong Li , Heinrich Schuchardt , David Abdurachmanov , Dimitri John Ledkov , U-Boot Mailing List , Mark Kettenis Subject: Re: [PATCH 1/1 RFC] treewide: Deprecate OF_PRIOR_STAGE Message-ID: <20211013175807.GY7964@bill-the-cat> References: <20210924131021.814662-1-ilias.apalodimas@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FFYQ0uwTm5Mjh7QP" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --FFYQ0uwTm5Mjh7QP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 13, 2021 at 01:36:00PM -0400, Thomas Fitzsimmons wrote: > Simon Glass writes: >=20 > [...] >=20 > > On Wed, 13 Oct 2021 at 10:26, Thomas Fitzsimmons = wrote: > >> > >> Simon Glass writes: > >> > >> [...] > >> > >> >> > I think one option is better than two. I have a slight preference= for > >> >> > OF_PRIOR_STAGE because it is board-agnostic, but I'm not sure it > >> >> > matters, since some of these boards are doing strange things anyw= ay > >> >> > and cannot use OF_PRIOR_STAGE. So let's go with this. > >> >> > >> >> For now it's easier getting rid of OF_PRIOR_STAGE than OF_BOARD. > >> >> Once we unify OF_PRIOR_STAGE/OF_BOARD and OF_HOSTFILE, then > >> >> I can send a patch on top of that, which removes the board_fdt_blob= _setup() > >> >> and just stores the address in a similar fashion to the removed > >> >> 'prior_stage_fdt_address'. That way we can get rid of architecture > >> >> specific constructs wrt to DT in gd. The callback is a bit more of= a pain to > >> >> maintain for multiple boards but is more flexible than an address i= n a > >> >> register. In any case we can do something along the lines of: > >> >> > >> >> Check register (or blob list or whatever) > >> >> if (valid dtb) > >> >> fixup/amend/use (depending on what we decide) > >> >> else > >> >> arch specific callback > >> >> > >> >> That should give us enough flexibility to deal with future boards (= famous > >> >> last words). > >> > > >> > SGTM > >> > >> This sounds like a good generalization that would still work for the > >> bcm7445 and bcm7260 boards. I'll test this approach on the evaluation > >> boards I have. > >> > >> For the BCM7445 I may be able to import the evaluation board device tr= ee > >> that Broadcom publishes as part of stblinux. At runtime I may need to > >> merge some of the in-memory items generated by BOLT, but I'll try to > >> make this work. > > > > That would be good. > > > >> The BCM7260 DTS is not publicly available though, as far as I know. > > > > Presumably it can be dumped from U-Boot? >=20 > Technically, yes, but I wouldn't want to publish the result for various > reasons; e.g., it would be specific to the evaluation boards I have, and > it may contain vendor-specific fields. I'd much rather this one remain > a stub, until/unless Broadcom publishes a generic BCM7260 DTS under a > free license. Also note that the notion that the U-Boot source tree _must_ contain a dts for a given board is something we're very much debating still, in another thread, if you're inclined to read and chime in there as well with more details about the broadcom use case and technical/legal limitations. Thanks! --=20 Tom --FFYQ0uwTm5Mjh7QP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFnHiUACgkQFHw5/5Y0 tyxMUwv/ZZp6N6kYVXdjzW/DCFf2ff2Is3gp7xWxI6hetLuT/ObNmtchbhsoQ0v2 Y0Fh4KLh8kIBlBTZ6c9jjAIII2faf9n50prZyvyF0m7Pm2ERcAVjWQ7iXaK2cvB9 oOo/BCIoTW7wQHg/efcwVaB+r5OWPTpWayGKjguNcCT8RM6sPcXDYgAalfsl5Az/ tvjPQ5HfMZRU18HF60v7gqEDgoLIsgkAgo4PRKE80kfbb0+04mw0eT84bkOmCD2w W1mV5QgOa6sUigArZqBVaoJLG/Rbb7eY3oYk9p/7XThIhSGqozT0lHoZhKEklYuW VwP3D9Ljn/DsU1nNzEoxACVN2N2D7y/qVQLfPPKekFsjayUBQ8SDwcVmgsVdJRgJ 4irUpWE5Xhbq+gaumvQA2NEmHy1S0pqlqKCJNAtsnrWj2OCWNZv4DNubmfSf/oI+ mlCCzbCsID7NNRwmfi6cAvLfFo03DJ373JsdPCo10XcQeEgibrvR9dceTAXVfjPu 6DUdAojf =a8sd -----END PGP SIGNATURE----- --FFYQ0uwTm5Mjh7QP--