public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Jorge Ramirez-Ortiz, Foundries" <jorge@foundries.io>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Jorge Ramirez-Ortiz <jorge@foundries.io>,
	u-boot@lists.denx.de, igor.opaniuk@foundries.io
Subject: Re: [PATCHv3] zynqmp: restore the jtag interface
Date: Thu, 14 Oct 2021 09:25:43 +0200	[thread overview]
Message-ID: <20211014072543.GA12760@trex> (raw)
In-Reply-To: <40d4fab9-6aae-6983-456d-3ccb940b972e@xilinx.com>

On 14/10/21, Michal Simek wrote:
> 
> 
> On 10/13/21 15:48, Jorge Ramirez-Ortiz wrote:
> > When boot.bin is configured for secure boot the CSU will disable the
> > JTAG interface on all cases.
> > 
> > Some boards might rely on this interface for flashing to QSPI in which
> > case those systems might end up bricked during development.
> > 
> > This commit will restore the interface under CSU control
> > 
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> > ---
> > 
> >   v3: delete unvalid removal of empty line
> > 
> >   arch/arm/mach-zynqmp/Kconfig                 |  8 +++++
> >   arch/arm/mach-zynqmp/include/mach/hardware.h | 31 +++++++++++++++-----
> >   board/xilinx/zynqmp/zynqmp.c                 | 19 ++++++++++++
> >   3 files changed, 51 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/arm/mach-zynqmp/Kconfig b/arch/arm/mach-zynqmp/Kconfig
> > index f7b08db355..ee0895d9a2 100644
> > --- a/arch/arm/mach-zynqmp/Kconfig
> > +++ b/arch/arm/mach-zynqmp/Kconfig
> > @@ -149,6 +149,14 @@ config SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
> >   	  Overwrite bootmode selected via boot mode pins to tell SPL what should
> >   	  be the next boot device.
> > +config SPL_ZYNQMP_RESTORE_JTAG
> > +	bool "Restore JTAG"
> > +	depends on SPL
> > +	help
> > +	 Booting SPL in secure mode causes the CSU to disable the JTAG interface
> > +	 even if no eFuses were burnt. This option restores the interface if
> > +	 possible.
> 
> here should be tab and 2 spaces.
>
ok

> I have fixed it myself and applied.

thanks a lot Michal for taking care of this

> M

  reply	other threads:[~2021-10-14  7:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 13:48 [PATCHv3] zynqmp: restore the jtag interface Jorge Ramirez-Ortiz
2021-10-14  7:14 ` Michal Simek
2021-10-14  7:25   ` Jorge Ramirez-Ortiz, Foundries [this message]
2021-11-01 16:23   ` Ricardo Salveti
2021-11-02  7:26     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211014072543.GA12760@trex \
    --to=jorge@foundries.io \
    --cc=igor.opaniuk@foundries.io \
    --cc=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox