From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45071C433EF for ; Thu, 14 Oct 2021 07:25:54 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E8F960F9E for ; Thu, 14 Oct 2021 07:25:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8E8F960F9E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 45AB88362E; Thu, 14 Oct 2021 09:25:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foundries.io header.i=@foundries.io header.b="L0X/TRA6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7EE6183639; Thu, 14 Oct 2021 09:25:49 +0200 (CEST) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4AE4D83624 for ; Thu, 14 Oct 2021 09:25:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jorge@foundries.io Received: by mail-wr1-x433.google.com with SMTP id g25so16377282wrb.2 for ; Thu, 14 Oct 2021 00:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foundries.io; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SeUqCn9XBQbmqTF+TAnW6+KeYeu4WqTDS+59Wn406rw=; b=L0X/TRA6ndfjrmbKylyHVO6DMdaW8adbPir2rzqZXrcAj9QLI2BUV/fmNxWVw8BaKL k3RlXBgo+viaRsPQUFNvi2+B/Mm2sYHpqEldr2Regn6mPQzAQwL1ROnhV4EOIgpV8y60 a3b7ERrjS2JGye13uf1CaGqQ7XYb0+OpZog71Dvwe20ZhicardR5oD4Y7Rqg5uGqfGnG Y4hrQfjiinI/VFR+0Phu5zHJ7I24AUiNFC0r0hdvZJIxq6uzDdRMUNSMrDCyVImLoPzM ZU5CmvgHhIr7cTp0IwgegExEQZjqy0UnndIovVoqPRNLeM3hXZ4x1eXCp3zEXb/jPwEr bN9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SeUqCn9XBQbmqTF+TAnW6+KeYeu4WqTDS+59Wn406rw=; b=v7cEcOKRyIuyHTKNBaV7y8x/yyZGIEZhOcLyfHSoJk0bI4+uc+wZynQ49tiyrjq6Ol Y9ci4cYxYlouYbBXcDRQVFuDqWLB6nOGLH6g/+JptZH61hoxSmb1uoh5f2V1Da950+cc 39ZRz2bwlamfI67n6qx06qV8Db02g7D5fyT0+frBPq5zhsOCY9Ry2mOU2SaK/IQ+ZsDw cpoftZYK5C6lOIRBQBM0/GGcWv9fOEU4/yaGZpm2LFitO0HLYfHZ6xGH1vDsdjfzCSWk KqCKNfBPiJY4P4ctFfLM3z/blShrwh9/NKT9IownkFK8DSlDbxiSA0uKwZvKcaWj/XG/ 1W8A== X-Gm-Message-State: AOAM531JWovRGpo+gd2PdTkkw8AiYjnA+NmffOY3pd4YgymveaAgZAh7 70GYK0/dqWjtV2gApGdbFhHO6w== X-Google-Smtp-Source: ABdhPJwVwodzoIWs6EPWFpWZOQNP07i+RlV8YMY/9U8UAl8wtHys46NxT9GKso9Eyrtwb4vAg0TIoQ== X-Received: by 2002:adf:a152:: with SMTP id r18mr4854954wrr.317.1634196345260; Thu, 14 Oct 2021 00:25:45 -0700 (PDT) Received: from trex (60.red-83-35-113.dynamicip.rima-tde.net. [83.35.113.60]) by smtp.gmail.com with ESMTPSA id s3sm1630902wrm.40.2021.10.14.00.25.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Oct 2021 00:25:44 -0700 (PDT) From: "Jorge Ramirez-Ortiz, Foundries" X-Google-Original-From: "Jorge Ramirez-Ortiz, Foundries" Date: Thu, 14 Oct 2021 09:25:43 +0200 To: Michal Simek Cc: Jorge Ramirez-Ortiz , u-boot@lists.denx.de, igor.opaniuk@foundries.io Subject: Re: [PATCHv3] zynqmp: restore the jtag interface Message-ID: <20211014072543.GA12760@trex> References: <20211013134800.19452-1-jorge@foundries.io> <40d4fab9-6aae-6983-456d-3ccb940b972e@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40d4fab9-6aae-6983-456d-3ccb940b972e@xilinx.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 14/10/21, Michal Simek wrote: > > > On 10/13/21 15:48, Jorge Ramirez-Ortiz wrote: > > When boot.bin is configured for secure boot the CSU will disable the > > JTAG interface on all cases. > > > > Some boards might rely on this interface for flashing to QSPI in which > > case those systems might end up bricked during development. > > > > This commit will restore the interface under CSU control > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > > > v3: delete unvalid removal of empty line > > > > arch/arm/mach-zynqmp/Kconfig | 8 +++++ > > arch/arm/mach-zynqmp/include/mach/hardware.h | 31 +++++++++++++++----- > > board/xilinx/zynqmp/zynqmp.c | 19 ++++++++++++ > > 3 files changed, 51 insertions(+), 7 deletions(-) > > > > diff --git a/arch/arm/mach-zynqmp/Kconfig b/arch/arm/mach-zynqmp/Kconfig > > index f7b08db355..ee0895d9a2 100644 > > --- a/arch/arm/mach-zynqmp/Kconfig > > +++ b/arch/arm/mach-zynqmp/Kconfig > > @@ -149,6 +149,14 @@ config SPL_ZYNQMP_ALT_BOOTMODE_ENABLED > > Overwrite bootmode selected via boot mode pins to tell SPL what should > > be the next boot device. > > +config SPL_ZYNQMP_RESTORE_JTAG > > + bool "Restore JTAG" > > + depends on SPL > > + help > > + Booting SPL in secure mode causes the CSU to disable the JTAG interface > > + even if no eFuses were burnt. This option restores the interface if > > + possible. > > here should be tab and 2 spaces. > ok > I have fixed it myself and applied. thanks a lot Michal for taking care of this > M