From: "Marek Behún" <marek.behun@nic.cz>
To: Kirill Kapranov <kirill.kapranov@compulab.co.il>,
Ye Li <ye.li@nxp.com>, Tom Rini <trini@konsulko.com>,
Peng Fan <peng.fan@nxp.com>
Cc: u-boot@lists.denx.de, Pantelis Antoniou <panto@antoniou-consulting.com>
Subject: Re: [PATCH 1/1] mmc: Fix mmc_switch excessive timeout
Date: Thu, 14 Oct 2021 16:51:32 +0200 [thread overview]
Message-ID: <20211014165132.50480ec1@dellmb> (raw)
In-Reply-To: <20211009204959.5864-1-kirill.kapranov@compulab.co.il>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
Tested-by: Marek Behún <marek.behun@nic.cz>
This fixes a bug introduced in commit 3f4e52fc9d81
https://source.denx.de/u-boot/u-boot/-/commit/3f4e52fc9d81e95ee90f6be7b05ca62fc8c7c1e3
and it is incorrect. It caused the mmc initialization to take 4 seconds
(previously it was <0.1s).
The code in Linux also uses &&, and the comment says:
If the host doesn't support HW polling via the ->card_busy() ops and
when it's not allowed to poll by using CMD13, then we need to rely on
waiting the stated timeout to be sufficient.
See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/core/mmc_ops.c?h=v5.15-rc5#n598
Peng, could we get this merged ASAP? :)
Marek
prev parent reply other threads:[~2021-10-14 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 20:49 [PATCH 1/1] mmc: Fix mmc_switch excessive timeout Kirill Kapranov
2021-10-14 14:51 ` Marek Behún [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014165132.50480ec1@dellmb \
--to=marek.behun@nic.cz \
--cc=kirill.kapranov@compulab.co.il \
--cc=panto@antoniou-consulting.com \
--cc=peng.fan@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox