From: "Marek Behún" <kabel@kernel.org>
To: Simon Glass <sjg@chromium.org>
Cc: "Tom Rini" <trini@konsulko.com>,
"U-Boot Mailing List" <u-boot@lists.denx.de>,
"Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH v2 04/13] env: Change env_match() to static and remove from header
Date: Thu, 14 Oct 2021 18:06:15 +0200 [thread overview]
Message-ID: <20211014180615.0fe06083@dellmb> (raw)
In-Reply-To: <CAPnjgZ2mTVNZ4pC6wQNdaAfG_vgm6aL3-W=CFKH-9Pz+XvX6hA@mail.gmail.com>
On Thu, 14 Oct 2021 09:11:08 -0600
Simon Glass <sjg@chromium.org> wrote:
> Hi Marek,
>
> On Wed, 13 Oct 2021 at 09:46, Marek Behún <kabel@kernel.org> wrote:
> >
> > From: Marek Behún <marek.behun@nic.cz>
> >
> > This function was used by other parts of U-Boot in the past when
> > environment was read from underlying device one character at a time.
> >
> > This is not the case anymore.
> >
> > Signed-off-by: Marek Behún <marek.behun@nic.cz>
> > ---
> > cmd/nvedit.c | 30 +++++++++++++++---------------
> > include/env.h | 11 -----------
> > 2 files changed, 15 insertions(+), 26 deletions(-)
> >
> > diff --git a/cmd/nvedit.c b/cmd/nvedit.c
> > index ddc715b4f9..742e0924af 100644
> > --- a/cmd/nvedit.c
> > +++ b/cmd/nvedit.c
> > @@ -706,6 +706,21 @@ char *from_env(const char *envvar)
> > return ret;
> > }
> >
>
> Please can you add the function comment here? We don't want to lose
> it.
Simon, the comment is invalid (the function does something
different from what the comment says) and the function is only used as a
helper by env_get_f(), which comes right after it. The function is
refactored and renamend in subsequent patches, and its purpose seems
obvious to me.
Should I really leave the comment there?
Marek
next prev parent reply other threads:[~2021-10-14 16:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 15:45 [PATCH v2 00/13] env_get_char() removal and env_get_f() refactor Marek Behún
2021-10-13 15:45 ` [PATCH v2 01/13] env: Fix documentation for env_get_f() Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 02/13] env: Drop env_get_char_spec() and old, unused .get_char() implementations Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 03/13] examples: api: glue: Remove comment that does not apply anymore Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 04/13] env: Change env_match() to static and remove from header Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-14 16:06 ` Marek Behún [this message]
2021-10-14 18:24 ` Simon Glass
2021-10-15 0:40 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 05/13] env: Don't match empty variable name in env_match() Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 06/13] env: Check for terminating null-byte " Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 07/13] env: Inline env_get_char() into it's only user Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 08/13] env: Early return from env_get_f() on NULL name Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 09/13] env: Use string pointer instead of indexes in env_get_f() Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-15 0:40 ` Simon Glass
2021-10-15 13:20 ` Marek Behún
2021-10-13 15:45 ` [PATCH v2 10/13] env: Use better name for variable " Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-15 0:40 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 11/13] env: Make return value of env_get_f() behave like sprintf() on success Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 12/13] env: Use memcpy() instead of ad-hoc code to copy variable value Marek Behún
2021-10-14 15:11 ` Simon Glass
2021-10-13 15:45 ` [PATCH v2 13/13] env: Move non-cmd specific env functions to env/common.c Marek Behún
2021-10-14 15:11 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014180615.0fe06083@dellmb \
--to=kabel@kernel.org \
--cc=marek.behun@nic.cz \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox