Re: [PATCH v2 02/13] env: Drop env_get_char_spec() and old, unused .get_char() implementations

Simon Glass
2021-10-14T15:14:52Z

On Wed, 13 Oct 2021 at 09:46, Marek Behún <kabel@kernel.org> wrote:
>
> From: Marek Behún <marek.behun@nic.cz>
>
> Commit b2cdef4861be ("env: restore old env_get_char() behaviour")
> dropped the .get_char() method from struct env_driver, but left the two
> existing implementations (eeprom and nvram) in case someone would use
> them by overwriting weak function env_get_char_spec().
>
> Since this was never done in the 3.5 years, let's drop these methods and
> simplify the code.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
> env/eeprom.c | 18 ------------------
> env/env.c | 7 +------
> env/nvram.c | 14 --------------
> 3 files changed, 1 insertion(+), 38 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>