[PATCH v2 00/13] env_get_char() removal and env_get_f() refactor

Marek Behún
2021-10-13T15:46:14Z

From: Marek Behún <marek.behun@nic.cz>

Hi Simon, Tom,

env_get_char() is a relic from the past when env was read char-by-char
from underlying device. Currently it only accesses in-memory arrays.
We can remove it and access the arrays directly. This simplifies the old
code of env_get_f().

Changes since v1:
- use memcpy() instead of strncpy() when copying value to buffer
- fixed a bug in patch adding check to terminating NULL-byte
- added patch fixing documentation for env_get_f()
- added patch changing behaviour of return value of env_get_f()
- some other cosmetic changes

Marek

Marek Behún (13):
env: Fix documentation for env_get_f()
env: Drop env_get_char_spec() and old, unused .get_char()
implementations
examples: api: glue: Remove comment that does not apply anymore
env: Change env_match() to static and remove from header
env: Don't match empty variable name in env_match()
env: Check for terminating null-byte in env_match()
env: Inline env_get_char() into it's only user
env: Early return from env_get_f() on NULL name
env: Use string pointer instead of indexes in env_get_f()
env: Use better name for variable in env_get_f()
env: Make return value of env_get_f() behave like sprintf() on success
env: Use memcpy() instead of ad-hoc code to copy variable value
env: Move non-cmd specific env functions to env/common.c

cmd/nvedit.c | 188 -------------------------------------------
env/common.c | 190 ++++++++++++++++++++++++++++++++++++++++++++
env/eeprom.c | 18 -----
env/env.c | 13 ---
env/nowhere.c | 5 +-
env/nvram.c | 14 ----
examples/api/glue.c | 5 --
include/env.h | 24 +-----
8 files changed, 194 insertions(+), 263 deletions(-)

--
2.32.0