Re: [PATCH v2 13/13] env: Move non-cmd specific env functions to env/common.c

Simon Glass
2021-10-14T15:16:23Z

On Wed, 13 Oct 2021 at 09:46, Marek Behún <kabel@kernel.org> wrote:
>
> From: Marek Behún <marek.behun@nic.cz>
>
> Move the following functions from cmd/nvedit.c to env/common.c:
> env_set_ulong()
> env_set_hex()
> env_get_hex()
> eth_env_get_enetaddr()
> eth_env_set_enetaddr()
> env_get()
> from_env()
> env_get_f()
> env_get_ulong()
> since these functions are not specific for U-Boot's CLI.
>
> We leave env_set() in cmd/nvedit.c, since it calls _do_env_set(), which
> is a static function in that file.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
> cmd/nvedit.c | 185 -------------------------------------------------
> env/common.c | 190 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 190 insertions(+), 185 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Subject: Move non-cmd-specific env functions//

or maybe Move non-cli env functions...