From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>,
Artem Lapkin <email2tema@gmail.com>,
Tom Rini <trini@konsulko.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Peter Hoyes <Peter.Hoyes@arm.com>, Simon Glass <sjg@chromium.org>
Subject: [PATCH v3 05/18] pxe: Add a userdata field to the context
Date: Thu, 14 Oct 2021 12:47:58 -0600 [thread overview]
Message-ID: <20211014184811.482560-6-sjg@chromium.org> (raw)
In-Reply-To: <20211014184811.482560-1-sjg@chromium.org>
Allow the caller to provide some info which is passed back to the
readfile() method.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v1)
cmd/pxe.c | 4 ++--
cmd/pxe_utils.c | 3 ++-
cmd/pxe_utils.h | 6 +++++-
cmd/sysboot.c | 2 +-
4 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/cmd/pxe.c b/cmd/pxe.c
index 70dbde3a636..d79b9b733d7 100644
--- a/cmd/pxe.c
+++ b/cmd/pxe.c
@@ -121,7 +121,7 @@ do_pxe_get(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
struct pxe_context ctx;
int err, i = 0;
- pxe_setup_ctx(&ctx, cmdtp, do_get_tftp);
+ pxe_setup_ctx(&ctx, cmdtp, do_get_tftp, NULL);
if (argc != 1)
return CMD_RET_USAGE;
@@ -175,7 +175,7 @@ do_pxe_boot(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
char *pxefile_addr_str;
struct pxe_context ctx;
- pxe_setup_ctx(&ctx, cmdtp, do_get_tftp);
+ pxe_setup_ctx(&ctx, cmdtp, do_get_tftp, NULL);
if (argc == 1) {
pxefile_addr_str = from_env("pxefile_addr_r");
diff --git a/cmd/pxe_utils.c b/cmd/pxe_utils.c
index 2caae6d1555..5ad6d3e3d44 100644
--- a/cmd/pxe_utils.c
+++ b/cmd/pxe_utils.c
@@ -1432,8 +1432,9 @@ void handle_pxe_menu(struct pxe_context *ctx, struct pxe_menu *cfg)
}
void pxe_setup_ctx(struct pxe_context *ctx, struct cmd_tbl *cmdtp,
- pxe_getfile_func getfile)
+ pxe_getfile_func getfile, void *userdata)
{
ctx->cmdtp = cmdtp;
ctx->getfile = getfile;
+ ctx->userdata = userdata;
}
diff --git a/cmd/pxe_utils.h b/cmd/pxe_utils.h
index ca2696f48b0..921455f694e 100644
--- a/cmd/pxe_utils.h
+++ b/cmd/pxe_utils.h
@@ -86,6 +86,7 @@ typedef int (*pxe_getfile_func)(struct pxe_context *ctx, const char *file_path,
*
* @cmdtp: Pointer to command table to use when calling other commands
* @getfile: Function called by PXE to read a file
+ * @userdata: Data the caller requires for @getfile
*/
struct pxe_context {
struct cmd_tbl *cmdtp;
@@ -99,6 +100,8 @@ struct pxe_context {
* Return 0 if OK, -ve on error
*/
pxe_getfile_func getfile;
+
+ void *userdata;
};
/**
@@ -192,8 +195,9 @@ int format_mac_pxe(char *outbuf, size_t outbuf_len);
* @ctx: Context to set up
* @cmdtp: Command table entry which started this action
* @getfile: Function to call to read a file
+ * @userdata: Data the caller requires for @getfile - stored in ctx->userdata
*/
void pxe_setup_ctx(struct pxe_context *ctx, struct cmd_tbl *cmdtp,
- pxe_getfile_func getfile);
+ pxe_getfile_func getfile, void *userdata);
#endif /* __PXE_UTILS_H */
diff --git a/cmd/sysboot.c b/cmd/sysboot.c
index 082f23543d1..5615e81e9ca 100644
--- a/cmd/sysboot.c
+++ b/cmd/sysboot.c
@@ -91,7 +91,7 @@ static int do_sysboot(struct cmd_tbl *cmdtp, int flag, int argc,
env_set("bootfile", filename);
}
- pxe_setup_ctx(&ctx, cmdtp, NULL);
+ pxe_setup_ctx(&ctx, cmdtp, NULL, NULL);
if (strstr(argv[3], "ext2")) {
ctx.getfile = do_get_ext2;
} else if (strstr(argv[3], "fat")) {
--
2.33.0.1079.g6e70778dc9-goog
next prev parent reply other threads:[~2021-10-14 18:49 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 18:47 [PATCH v3 00/18] pxe: Refactoring to tidy up and prepare for bootflow Simon Glass
2021-10-14 18:47 ` [PATCH v3 01/18] Create a new boot/ directory Simon Glass
2021-10-16 5:31 ` Art Nikpal
2021-10-18 8:41 ` art
2021-11-12 15:38 ` Tom Rini
2021-10-14 18:47 ` [PATCH v3 02/18] pxe: Move API comments to the header files Simon Glass
2021-10-18 8:42 ` art
2021-11-09 8:07 ` Ramon Fried
2021-11-09 8:52 ` Heinrich Schuchardt
2021-11-12 15:38 ` Tom Rini
2021-10-14 18:47 ` [PATCH v3 03/18] pxe: Use a context pointer Simon Glass
2021-10-18 8:45 ` art
2021-11-09 8:08 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:47 ` [PATCH v3 04/18] pxe: Move do_getfile() into the context Simon Glass
2021-10-18 8:46 ` art
2021-11-09 8:11 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:47 ` Simon Glass [this message]
2021-10-18 8:46 ` [PATCH v3 05/18] pxe: Add a userdata field to " art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:47 ` [PATCH v3 06/18] pxe: Tidy up the is_pxe global Simon Glass
2021-10-18 8:47 ` art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 07/18] pxe: Move pxe_utils files Simon Glass
2021-10-18 8:47 ` art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2022-02-09 11:40 ` Adam Ford
2022-02-09 12:32 ` Tom Rini
2022-02-09 17:16 ` Simon Glass
2022-02-10 13:56 ` Adam Ford
2022-02-10 13:57 ` Adam Ford
2022-02-10 14:32 ` Simon Glass
2022-02-10 14:41 ` Adam Ford
2022-02-10 14:57 ` Tom Rini
2022-02-11 15:50 ` Adam Ford
2022-02-11 16:12 ` Tom Rini
2022-02-11 16:39 ` Adam Ford
2022-02-11 16:44 ` Tom Rini
2022-02-11 17:10 ` Adam Ford
2022-02-11 17:13 ` Tom Rini
2022-02-12 1:09 ` Adam Ford
2022-02-12 1:43 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 08/18] pxe: Tidy up some comments in pxe_utils Simon Glass
2021-10-18 8:48 ` art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 09/18] pxe: Tidy up code style a little " Simon Glass
2021-10-18 8:48 ` art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 10/18] pxe: Move common parsing coding into pxe_util Simon Glass
2021-10-18 8:49 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 11/18] pxe: Clean up the use of bootfile Simon Glass
2021-10-18 8:51 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 12/18] pxe: Drop get_bootfile_path() Simon Glass
2021-10-18 8:51 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 13/18] lib: Add tests for simple_itoa() Simon Glass
2021-10-18 8:30 ` art
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 14/18] lib: Add a function to convert a string to a hex value Simon Glass
2021-10-18 8:52 ` art
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 15/18] pxe: Return the file size from the getfile() function Simon Glass
2021-10-18 8:53 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 16/18] pxe: Refactor sysboot to have one helper Simon Glass
2021-10-18 8:54 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 17/18] doc: Move distro boot doc to rST Simon Glass
2021-10-18 8:55 ` art
2021-11-09 8:08 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 18/18] pxe: Allow calling the pxe_get logic directly Simon Glass
2021-10-18 8:56 ` art
2021-11-09 8:07 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-15 10:27 ` [PATCH v3 00/18] pxe: Refactoring to tidy up and prepare for bootflow Art Nikpal
2021-10-26 1:28 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014184811.482560-6-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=Peter.Hoyes@arm.com \
--cc=email2tema@gmail.com \
--cc=joe.hershberger@ni.com \
--cc=patrice.chotard@foss.st.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox