From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH] buildman: Add gcc-11.1.0 to the directory list
Date: Thu, 14 Oct 2021 21:28:24 -0400 [thread overview]
Message-ID: <20211015012824.GL7964@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ12NA4n8oiW+fK_xaxXr91PD28NxQ2MgmBNbhmsXL_5uA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]
On Thu, Oct 14, 2021 at 07:25:24PM -0600, Simon Glass wrote:
> Hi Tom,
>
> On Thu, 14 Oct 2021 at 19:12, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Oct 14, 2021 at 07:05:33PM -0600, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Tue, 5 Oct 2021 at 10:20, Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > While CI has been using gcc-11.1.0 for a long time, we have not updated
> > > > buildman to match. Correct this omission.
> > > >
> > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > > ---
> > > > tools/buildman/toolchain.py | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py
> > > > index fd137f7300e7..4e2471f3e370 100644
> > > > --- a/tools/buildman/toolchain.py
> > > > +++ b/tools/buildman/toolchain.py
> > > > @@ -498,7 +498,7 @@ class Toolchains:
> > > > if arch == 'aarch64':
> > > > arch = 'arm64'
> > > > base = 'https://www.kernel.org/pub/tools/crosstool/files/bin'
> > > > - versions = ['9.2.0', '7.3.0', '6.4.0', '4.9.4']
> > > > + versions = ['11.1.0', '9.2.0', '7.3.0', '6.4.0', '4.9.4']
> > > > links = []
> > > > for version in versions:
> > > > url = '%s/%s/%s/' % (base, arch, version)
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > This seems to break that n900 build:
> > >
> > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/jobs/336316
> >
> > *headdesk* the test hard-codes the toolchain version to add to PATH.
>
> It might be a good oppty to put some of its downloads into the docker image?
Well, it's the CI files that had been hard-coding the path (I was a bit
quick before), and should instead be using the one that's already in the
image, yes. So let me fire off something to fix that, and it just needs
to be in your tree before the other patch, to preserve bisectability.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-10-15 1:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 16:20 [PATCH] buildman: Add gcc-11.1.0 to the directory list Tom Rini
2021-10-15 1:05 ` Simon Glass
2021-10-15 1:12 ` Tom Rini
2021-10-15 1:25 ` Simon Glass
2021-10-15 1:28 ` Tom Rini [this message]
2021-10-21 18:49 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015012824.GL7964@bill-the-cat \
--to=trini@konsulko.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox