From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bin Meng <bmeng.cn@gmail.com>, Simon Glass <sjg@chromium.org>,
u-boot@lists.denx.de
Subject: [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration
Date: Fri, 15 Oct 2021 20:11:47 +0300 [thread overview]
Message-ID: <20211015171147.51948-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20211015171147.51948-1-andriy.shevchenko@linux.intel.com>
There are two PCB designs in the wild which use the opposite
signaling for SD card detect. This makes U-Boot working in one case
and failing in the other. Quirk this out by disconnecting SD card
detect pin from the PCB by switching to mode 3.
BugLink: https://github.com/edison-fw/meta-intel-edison/issues/136
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/dts/edison.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts
index 2c8cf6c07102..04e8a4e457c8 100644
--- a/arch/x86/dts/edison.dts
+++ b/arch/x86/dts/edison.dts
@@ -94,6 +94,7 @@
sdcard: mmc@ff3fa000 {
compatible = "intel,sdhci-tangier";
reg = <0xff3fa000 0x1000>;
+ cd-inverted;
};
pmu: power@ff00b000 {
@@ -131,6 +132,17 @@
compatible = "intel,pinctrl-tangier";
reg = <0xff0c0000 0x8000>;
+ /*
+ * Disconnect SD card detect, so it won't affect the reality
+ * on two different PCB designs where it's using the opposite
+ * signaling: Edison/Arduino uses Active Low, while SparkFun
+ * went with Active High.
+ */
+ sd_cd@0 {
+ pad-offset = <37>;
+ mode-func = <3>;
+ };
+
/*
* Initial configuration came from the firmware.
* Which quite likely has been used in the phones, where I2C #8,
--
2.33.0
next prev parent reply other threads:[~2021-10-15 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 17:11 [PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver Andy Shevchenko
2021-10-15 17:11 ` Andy Shevchenko [this message]
2021-10-20 21:00 ` [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration Ferry Toth
2021-10-21 8:20 ` Andy Shevchenko
2021-10-27 2:56 ` Bin Meng
2021-10-27 8:51 ` Andy Shevchenko
2021-10-27 10:10 ` Bin Meng
2021-10-27 11:16 ` Andy Shevchenko
2021-10-27 2:49 ` [PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver Bin Meng
2021-10-27 8:53 ` Andy Shevchenko
2021-10-27 10:14 ` Bin Meng
2021-10-27 10:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015171147.51948-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bmeng.cn@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox