Re: [PATCH 4/4] Convert CONFIG_USB_EHCI_IS_TDI to Kconfig

Marek Behún
2022-05-18T08:07:38Z

On Wed, 18 May 2022 16:44:32 +1200
Chris Packham <judge.packham@gmail.com> wrote:

> Hi Marek,
>
> On Sun, Oct 10, 2021 at 2:28 AM Marek Behún <kabel@kernel.org> wrote:
> >
> > From: Marek Behún <marek.behun@nic.cz>
> >
> > On mvebu this is defined if and only if !ARM64.
> >
>
> I'm working on a 64-bit MVEBU board which I'll hopefully be submitting
> soon (just getting the Linux stuff sorted first). Was there any
> particular reason you added the !ARM64 ? My board appears to need
> CONFIG_USB_EHCI_IS_TDI=y. I can make the condition more complicated if
> necessary but it might just be easier to remove the !ARM64.

It was because only arm32 boards defined it in the config headers when
I was converting. So I converted it so that Kconfig selected that if
!ARM64.

> > Otherwise it is defined for boards with ARCH_MX23, ARCH_TEGRA and
> > ARCH_ZYNQ, and also for SOC_AR934X (tplink_wdr4300).
> >
> > Signed-off-by: Marek Behún <marek.behun@nic.cz>
> > ---
>
> <snip>
>
> > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > index be5e4b994d..ccecb5a3b0 100644
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -139,6 +139,9 @@ config USB_EHCI_HCD
> >
> > if USB_EHCI_HCD
> >
> > +config USB_EHCI_IS_TDI
> > + bool
> > +
> > config USB_EHCI_ATMEL
> > bool "Support for Atmel on-chip EHCI USB controller"
> > depends on ARCH_AT91
> > @@ -150,6 +153,7 @@ config USB_EHCI_MARVELL
> > bool "Support for Marvell on-chip EHCI USB controller"
> > depends on ARCH_MVEBU || ARCH_KIRKWOOD || ARCH_ORION5X
> > default y
> > + select USB_EHCI_IS_TDI if !ARM64
>
> Here I'm thinking about something like if !ARM64 || ALLEYCAT_5

Sure, if you need this, do this. Just make sure it does not get
selected for boards that don't need it.

Marek