* [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400 @ 2021-10-15 8:41 ` Yifeng Zhao 2021-10-15 12:40 ` Kever Yang 2021-10-17 22:07 ` Jaehoon Chung 0 siblings, 2 replies; 5+ messages in thread From: Yifeng Zhao @ 2021-10-15 8:41 UTC (permalink / raw) To: Jaehoon Chung, sjg, Kever Yang Cc: Peng Fan, Philipp Tomsich, u-boot, Philipp Zabel, Yifeng Zhao The default configuration of rk3399 EMMC PHY does not enable the strobe line, and EMMC controller will got data transmission error at HS400 mode. Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> --- drivers/mmc/rockchip_sdhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index 1ac00587d4..278473899c 100644 --- a/drivers/mmc/rockchip_sdhci.c +++ b/drivers/mmc/rockchip_sdhci.c @@ -143,6 +143,9 @@ static void rk3399_emmc_phy_power_on(struct rockchip_emmc_phy *phy, u32 clock) writel(RK_CLRSETBITS(3 << 12, freqsel << 12), &phy->emmcphy_con[0]); writel(RK_CLRSETBITS(1 << 1, 1 << 1), &phy->emmcphy_con[6]); + /* REN Enable on STRB Line for HS400 */ + writel(RK_CLRSETBITS(0, 1 << 9), &phy->emmcphy_con[2]); + read_poll_timeout(readl, &phy->emmcphy_status, dllrdy, PHYCTRL_DLL_LOCK_WO_TMOUT(dllrdy), 1, 5000); } -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400 2021-10-15 8:41 ` [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400 Yifeng Zhao @ 2021-10-15 12:40 ` Kever Yang 2021-10-17 22:07 ` Jaehoon Chung 1 sibling, 0 replies; 5+ messages in thread From: Kever Yang @ 2021-10-15 12:40 UTC (permalink / raw) To: Yifeng Zhao, Jaehoon Chung, sjg Cc: Peng Fan, Philipp Tomsich, u-boot, Philipp Zabel On 2021/10/15 下午4:41, Yifeng Zhao wrote: > The default configuration of rk3399 EMMC PHY does not enable the > strobe line, and EMMC controller will got data transmission error > at HS400 mode. > > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > > drivers/mmc/rockchip_sdhci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c > index 1ac00587d4..278473899c 100644 > --- a/drivers/mmc/rockchip_sdhci.c > +++ b/drivers/mmc/rockchip_sdhci.c > @@ -143,6 +143,9 @@ static void rk3399_emmc_phy_power_on(struct rockchip_emmc_phy *phy, u32 clock) > writel(RK_CLRSETBITS(3 << 12, freqsel << 12), &phy->emmcphy_con[0]); > writel(RK_CLRSETBITS(1 << 1, 1 << 1), &phy->emmcphy_con[6]); > > + /* REN Enable on STRB Line for HS400 */ > + writel(RK_CLRSETBITS(0, 1 << 9), &phy->emmcphy_con[2]); > + > read_poll_timeout(readl, &phy->emmcphy_status, dllrdy, > PHYCTRL_DLL_LOCK_WO_TMOUT(dllrdy), 1, 5000); > } ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400 2021-10-15 8:41 ` [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400 Yifeng Zhao 2021-10-15 12:40 ` Kever Yang @ 2021-10-17 22:07 ` Jaehoon Chung 2021-10-18 1:08 ` 赵仪峰 1 sibling, 1 reply; 5+ messages in thread From: Jaehoon Chung @ 2021-10-17 22:07 UTC (permalink / raw) To: Yifeng Zhao, sjg, Kever Yang Cc: Peng Fan, Philipp Tomsich, u-boot, Philipp Zabel On 10/15/21 5:41 PM, Yifeng Zhao wrote: > The default configuration of rk3399 EMMC PHY does not enable the > strobe line, and EMMC controller will got data transmission error > at HS400 mode. > > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > --- > > drivers/mmc/rockchip_sdhci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c > index 1ac00587d4..278473899c 100644 > --- a/drivers/mmc/rockchip_sdhci.c > +++ b/drivers/mmc/rockchip_sdhci.c > @@ -143,6 +143,9 @@ static void rk3399_emmc_phy_power_on(struct rockchip_emmc_phy *phy, u32 clock) > writel(RK_CLRSETBITS(3 << 12, freqsel << 12), &phy->emmcphy_con[0]); > writel(RK_CLRSETBITS(1 << 1, 1 << 1), &phy->emmcphy_con[6]); > > + /* REN Enable on STRB Line for HS400 */ > + writel(RK_CLRSETBITS(0, 1 << 9), &phy->emmcphy_con[2]); > + Just wonder about doesn't it affect to other mode? Best Regards, Jaehoon Chung > read_poll_timeout(readl, &phy->emmcphy_status, dllrdy, > PHYCTRL_DLL_LOCK_WO_TMOUT(dllrdy), 1, 5000); > } > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Re: [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400 2021-10-17 22:07 ` Jaehoon Chung @ 2021-10-18 1:08 ` 赵仪峰 2021-10-18 1:52 ` Jaehoon Chung 0 siblings, 1 reply; 5+ messages in thread From: 赵仪峰 @ 2021-10-18 1:08 UTC (permalink / raw) To: Jaehoon Chung, sjg, 杨凯 Cc: Peng Fan, Philipp Tomsich, u-boot, Philipp Zabel Hi Jaehoon > Just wonder about doesn't it affect to other mode? The strobe line will only be used in hs400 mode and will not affect other modes. Best Regards, Yifeng Zhao > On 10/15/21 5:41 PM, Yifeng Zhao wrote: > The default configuration of rk3399 EMMC PHY does not enable the > strobe line, and EMMC controller will got data transmission error > at HS400 mode. > > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > --- > > drivers/mmc/rockchip_sdhci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c > index 1ac00587d4..278473899c 100644 > --- a/drivers/mmc/rockchip_sdhci.c > +++ b/drivers/mmc/rockchip_sdhci.c > @@ -143,6 +143,9 @@ static void rk3399_emmc_phy_power_on(struct rockchip_emmc_phy *phy, u32 clock) > writel(RK_CLRSETBITS(3 << 12, freqsel << 12), &phy->emmcphy_con[0]); > writel(RK_CLRSETBITS(1 << 1, 1 << 1), &phy->emmcphy_con[6]); > > + /* REN Enable on STRB Line for HS400 */ > + writel(RK_CLRSETBITS(0, 1 << 9), &phy->emmcphy_con[2]); > + Just wonder about doesn't it affect to other mode? Best Regards, Jaehoon Chung > read_poll_timeout(readl, &phy->emmcphy_status, dllrdy, > PHYCTRL_DLL_LOCK_WO_TMOUT(dllrdy), 1, 5000); > } > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400 2021-10-18 1:08 ` 赵仪峰 @ 2021-10-18 1:52 ` Jaehoon Chung 0 siblings, 0 replies; 5+ messages in thread From: Jaehoon Chung @ 2021-10-18 1:52 UTC (permalink / raw) To: 赵仪峰, sjg, 杨凯 Cc: Peng Fan, Philipp Tomsich, u-boot, Philipp Zabel Hi Yifeng, On 10/18/21 10:08 AM, 赵仪峰 wrote: > Hi Jaehoon > >> Just wonder about doesn't it affect to other mode? > > The strobe line will only be used in hs400 mode and will not affect other modes. > > Best Regards, > Yifeng Zhao > >> > On 10/15/21 5:41 PM, Yifeng Zhao wrote: >> The default configuration of rk3399 EMMC PHY does not enable the >> strobe line, and EMMC controller will got data transmission error >> at HS400 mode. >> >> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung >> --- >> >> drivers/mmc/rockchip_sdhci.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c >> index 1ac00587d4..278473899c 100644 >> --- a/drivers/mmc/rockchip_sdhci.c >> +++ b/drivers/mmc/rockchip_sdhci.c >> @@ -143,6 +143,9 @@ static void rk3399_emmc_phy_power_on(struct rockchip_emmc_phy *phy, u32 clock) >> writel(RK_CLRSETBITS(3 << 12, freqsel << 12), &phy->emmcphy_con[0]); >> writel(RK_CLRSETBITS(1 << 1, 1 << 1), &phy->emmcphy_con[6]); >> >> + /* REN Enable on STRB Line for HS400 */ >> + writel(RK_CLRSETBITS(0, 1 << 9), &phy->emmcphy_con[2]); >> + > > Just wonder about doesn't it affect to other mode? > > > Best Regards, > Jaehoon Chung > >> read_poll_timeout(readl, &phy->emmcphy_status, dllrdy, >> PHYCTRL_DLL_LOCK_WO_TMOUT(dllrdy), 1, 5000); >> } >> > > > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-18 1:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20211015084147epcas1p3e1a65248a2b3c0f6d776bbb58ca9409a@epcas1p3.samsung.com>
2021-10-15 8:41 ` [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400 Yifeng Zhao
2021-10-15 12:40 ` Kever Yang
2021-10-17 22:07 ` Jaehoon Chung
2021-10-18 1:08 ` 赵仪峰
2021-10-18 1:52 ` Jaehoon Chung
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox