[PATCH] mtd: spi-nor-ids: Add is25lp512 and is25wp512 devices

[PATCH] mtd: spi-nor-ids: Add is25lp512 and is25wp512 devices

[Kris Chaplin]

Add is25lp512 and is25wp512 devices to spi-nor id table

Tested on Intel n5x hardware with QSPI carrier card

Signed-off-by: Kris Chaplin <kris.chaplin@linux.intel.com>
Tested-by: Kris Chaplin <kris.chaplin@linux.intel.com>
---
 drivers/mtd/spi/spi-nor-ids.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 6ca669c591..5359d09489 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -133,6 +133,8 @@ const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ) },
 	{ INFO("is25lp256",  0x9d6019, 0, 64 * 1024, 512,
 			SECT_4K | SPI_NOR_DUAL_READ) },
+	{ INFO("is25lp512",  0x9d601a, 0, 64 * 1024, 1024,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("is25wp032",  0x9d7016, 0, 64 * 1024,  64,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("is25wp064",  0x9d7017, 0, 64 * 1024, 128,
@@ -142,6 +144,8 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("is25wp256",  0x9d7019, 0, 64 * 1024, 512,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_4B_OPCODES) },
+	{ INFO("is25wp512",  0x9d701a, 0, 64 * 1024, 1024,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 #endif
 #ifdef CONFIG_SPI_FLASH_MACRONIX	/* MACRONIX */
 	/* Macronix */
-- 
2.25.1

Re: [PATCH] mtd: spi-nor-ids: Add is25lp512 and is25wp512 devices

[Pratyush Yadav]

On 18/10/21 03:26AM, Kris Chaplin wrote:
> Add is25lp512 and is25wp512 devices to spi-nor id table
> 
> Tested on Intel n5x hardware with QSPI carrier card
> 
> Signed-off-by: Kris Chaplin <kris.chaplin@linux.intel.com>
> Tested-by: Kris Chaplin <kris.chaplin@linux.intel.com>

Same comment as before about the Tested-by trailer. Also adding SPI NOR 
maintainers in Cc, as mentioned in previous email.

I dunno much about these flashes so I am not commenting on the patch 
contents.

> ---
>  drivers/mtd/spi/spi-nor-ids.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 6ca669c591..5359d09489 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -133,6 +133,8 @@ const struct flash_info spi_nor_ids[] = {
>  			SECT_4K | SPI_NOR_DUAL_READ) },
>  	{ INFO("is25lp256",  0x9d6019, 0, 64 * 1024, 512,
>  			SECT_4K | SPI_NOR_DUAL_READ) },
> +	{ INFO("is25lp512",  0x9d601a, 0, 64 * 1024, 1024,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  	{ INFO("is25wp032",  0x9d7016, 0, 64 * 1024,  64,
>  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  	{ INFO("is25wp064",  0x9d7017, 0, 64 * 1024, 128,
> @@ -142,6 +144,8 @@ const struct flash_info spi_nor_ids[] = {
>  	{ INFO("is25wp256",  0x9d7019, 0, 64 * 1024, 512,
>  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>  			SPI_NOR_4B_OPCODES) },
> +	{ INFO("is25wp512",  0x9d701a, 0, 64 * 1024, 1024,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  #endif
>  #ifdef CONFIG_SPI_FLASH_MACRONIX	/* MACRONIX */
>  	/* Macronix */
> -- 
> 2.25.1
> 

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.