From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4049DC433F5 for ; Tue, 19 Oct 2021 12:05:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A86C60F8F for ; Tue, 19 Oct 2021 12:05:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6A86C60F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DDDD282EA6; Tue, 19 Oct 2021 14:05:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gsyd0SrF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3CCD28128D; Tue, 19 Oct 2021 10:18:05 +0200 (CEST) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 38AD88119C for ; Tue, 19 Oct 2021 10:18:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=schspa@gmail.com Received: by mail-qv1-xf34.google.com with SMTP id v2so11759303qve.11 for ; Tue, 19 Oct 2021 01:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qGWcEYOiuzgShzO30durG75V3Z5debTTMTj0aG3M7v4=; b=gsyd0SrFFfoPZjPZKKlm5YsA5ezKV0R02vsVa0b0UXNC2zbWFXE0XRzGumpBftk3fh EqLPc/c9eRvmudAaAy2ao1aq6wVN0DNU8yW+eSITvz4XeKyq3rmx1J9ywfPWTuDTUt9u g5e2uYbdkzkaT8srIQTpsUNTT7fMqyXmG5qSO2bn3cdLEdrl9ax1R2///72hr0b6dy7r C2VqyLhRVDHVu6DgtqWkbvylcCcD+VV/wOqm3jPXOdcajFLAFBW0kZSJbPsLVHKg+eA0 nTlIJEuVsk4XnBOwgPX3rU26EoBE9/QrPRPQo9V4m5htnXN4mJaHwIAbUY0WI/ym6JcV kuZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qGWcEYOiuzgShzO30durG75V3Z5debTTMTj0aG3M7v4=; b=GXtzodOzO6ALR/4rV2YKPIgUCkzn3zSToU/sgLNhXLS+bAAgrlaAp9H/CKrFM/Q06U Mw5cZ2h3isz7D0fxM+nhOXlaWIFI8texLWhUT5md98OTJ2zibwGlUTXzO9OcsnwZ1FD0 tX+ezPGQU+BDgAU138aOCYS0hmbnf/1sIKkECiEilCvjce0yvJ6/asxTNmgnHZDeWInw VhAyudLRDR36hC6wIDZEBByKJ1WLc+ornkuxlQQOglsVOzlcw6Yj7Nyrybry+Y7fRajH DXihEIjrrAcAh8LLPmY+0A6OcaSmByS9Md9UIo+LkfYMZYgZhBMihlmmYe8PYzVIC9PW pgrA== X-Gm-Message-State: AOAM531lpD6glMupihwcPeAiDNryBqgFbvGwLtwy6R4jdX4dvzZBFiO9 UsS1/cjjbcok5HVRZCXI2y24OSJVv/k= X-Google-Smtp-Source: ABdhPJy/1DB6u2DyqPkCYPCll3AuJ879flQ7yibRSzTHQbRVex5HOHFtY0kQOSjMQP4a/yU55MmBqA== X-Received: by 2002:ad4:5ba3:: with SMTP id 3mr29672821qvq.60.1634631479630; Tue, 19 Oct 2021 01:17:59 -0700 (PDT) Received: from localhost (ec2-3-142-145-253.us-east-2.compute.amazonaws.com. [3.142.145.253]) by smtp.gmail.com with ESMTPSA id h68sm7802834qkf.126.2021.10.19.01.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 01:17:59 -0700 (PDT) From: schspa To: u-boot@lists.denx.de Cc: sjg@chromium.org, seanga2@gmail.com, schspa@gmail.com, xypron.glpk@gmx.de Subject: [PATCH] part: return -ENOSYS when get_info not valid. Date: Tue, 19 Oct 2021 16:17:51 +0800 Message-Id: <20211019081751.3528905-1-schspa@gmail.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 19 Oct 2021 14:05:24 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean In some case, get_info() interface can be NULL, add this check to stop from crash. Signed-off-by: schspa --- disk/part.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/disk/part.c b/disk/part.c index a6a8f7052b..7af3240ec7 100644 --- a/disk/part.c +++ b/disk/part.c @@ -668,6 +668,13 @@ int part_get_info_by_name_type(struct blk_desc *dev_desc, const char *name, part_drv = part_driver_lookup_type(dev_desc); if (!part_drv) return -1; + + if (!part_drv->get_info) { + PRINTF("## Driver %s does not have the get_info() method\n", + part_drv->name); + return -ENOSYS; + } + for (i = 1; i < part_drv->max_entries; i++) { ret = part_drv->get_info(dev_desc, i, info); if (ret != 0) { -- 2.33.1