Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

Wolfgang Denk
2021-10-21T09:10:27Z

Dear Simon,

In message <CAPnjgZ00MfCPTpUkD_=dgC463ve4cqXj0c=2xFEYX2yqtsEk8w@mail.gmail.com> you wrote:
>
> > Wait saying we'll add "+SOMETHING" is a common case?
>
> Yes we have places where we add to env vars depending on CONFIG settings.

Yes, but how many places are there where the appended value starts
with a '+' ?

> The way I have this, is it fairly trivial to convert an existing
> script to a text file. I suspect it can be done automatically but I
> have not actually tried it. I'd really like to keep it simple. I also
> want to invoke the 'if you are not in mainline you don't exist' maxim
> at this point.

In which way is "+=" easier to parse than "=+"? The only extension
you have to make is for the "=[^+]" case to check the first charater
of the value: if it is a backslash, then ignore it.

This has zero influence on doing this manually or automatic.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
I see that Microsoft's campaign to destroy all knowledge of any
operating environment but its own environment-of-the-year has
succeeded in creating a generation of users who don't understand the
concept of a shell...
-- L. Peter Deutsch in <m0x5jNX-000R2UC@lamp.aladdin.com>