From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A75C433F5 for ; Tue, 19 Oct 2021 16:07:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCDB261038 for ; Tue, 19 Oct 2021 16:07:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BCDB261038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 49E2E82DB4; Tue, 19 Oct 2021 18:07:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="hWgAL3A9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 181C98314B; Tue, 19 Oct 2021 18:07:53 +0200 (CEST) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E68E3805F9 for ; Tue, 19 Oct 2021 18:07:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPSA id A5C2F13FCFD; Tue, 19 Oct 2021 18:07:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1634659669; bh=S1U/uD0LLWbtRS9zMCp5ijjFbjPjF0cr8Sld+SjHcqM=; h=Date:From:To; b=hWgAL3A93Yw3qbV8G8qsZK19k0OYSrRB6htrE5k6+Nx7SWH1XfkpNucrZEcfsTTv9 T9/VDRjfXvkQ22hbVj9wiJkEb5Iz/sZQJ2wBbIe9cbmphLgVrkHn+wmBmibCYPxfxk wJ3284FJgL/k69pLR2cjk2/Ds0qbif/LBvzkiucs= Date: Tue, 19 Oct 2021 18:07:49 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Simon Glass Cc: U-Boot Mailing List , Rasmus Villemoes , Heinrich Schuchardt , Wolfgang Denk , Tom Rini Subject: Re: [PATCH v8 5/8] sandbox: Use a text-based environment Message-ID: <20211019180749.25fb5f11@thinkpad> In-Reply-To: References: <20211018181322.1181847-1-sjg@chromium.org> <20211018121315.v8.5.I0690bd21a0701ccc5dd95fb5df88519d216d8af5@changeid> <20211019163246.461ca41d@thinkpad> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 19 Oct 2021 09:52:14 -0600 Simon Glass wrote: > Hi Marek, >=20 > On Tue, 19 Oct 2021 at 08:32, Marek Beh=C3=BAn wrote: > > > > On Mon, 18 Oct 2021 12:13:19 -0600 > > Simon Glass wrote: > > =20 > > > --- /dev/null > > > +++ b/board/sandbox/sandbox.env > > > @@ -0,0 +1,25 @@ > > > +stdin=3Dserial > > > +#ifdef CONFIG_SANDBOX_SDL > > > +stdin+=3D,cros-ec-keyb,usbkbd =20 > > > > this was CONFIG_KEYBOARD and now is CONFIG_SANDBOX_SDL, is this okay? = =20 >=20 > The old code is: >=20 > #ifdef CONFIG_SANDBOX_SDL > #define LCD_BPP LCD_COLOR16 > #define CONFIG_LCD_BMP_RLE8 >=20 > #define CONFIG_KEYBOARD >=20 > #define SANDBOX_SERIAL_SETTINGS "stdin=3Dserial,cros-ec-keyb,usbkbd\0" \ > "stdout=3Dserial,vidconsole\0" \ > "stderr=3Dserial,vidconsole\0" > #else > #define SANDBOX_SERIAL_SETTINGS "stdin=3Dserial\0" \ > "stdout=3Dserial,vidconsole\0" \ > "stderr=3Dserial,vidconsole\0" > #endif >=20 >=20 > so really the check is on CONFIG_SANDBOX_SDL. The setting of > CONFIG_KEYBOARD is not related to the environment. Ah, sorry. In that case Reviewed-by: Marek Beh=C3=BAn