From: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
To: <lukma@denx.de>, <sjg@chromium.org>, <trini@konsulko.com>,
<mr.nuke.me@gmail.com>, <u-boot@lists.denx.de>
Cc: <joel@jms.id.au>, <ryan_chen@aspeedtech.com>,
<johnny_huang@aspeedtech.com>
Subject: [PATCH next v7 01/12] image: fit: Fix parameter name for hash algorithm
Date: Wed, 20 Oct 2021 10:49:22 +0800 [thread overview]
Message-ID: <20211020024933.16964-2-chiawei_wang@aspeedtech.com> (raw)
In-Reply-To: <20211020024933.16964-1-chiawei_wang@aspeedtech.com>
Fix inconsistent function parameter name of the hash algorithm.
Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Fixes: 92055e138f2 ("image: Drop if/elseif hash selection in calculate_hash()")
---
common/image-fit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/image-fit.c b/common/image-fit.c
index 5a0a0cc200..a53a2b5d6f 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -1201,7 +1201,7 @@ int fit_set_timestamp(void *fit, int noffset, time_t timestamp)
* calculate_hash - calculate and return hash for provided input data
* @data: pointer to the input data
* @data_len: data length
- * @algo: requested hash algorithm
+ * @name: requested hash algorithm name
* @value: pointer to the char, will hold hash value data (caller must
* allocate enough free space)
* value_len: length of the calculated hash
@@ -1229,7 +1229,7 @@ int calculate_hash(const void *data, int data_len, const char *name,
return -1;
}
- hash_algo = hash_algo_lookup_by_name(algo);
+ hash_algo = hash_algo_lookup_by_name(name);
if (hash_algo == HASH_ALGO_INVALID) {
debug("Unsupported hash algorithm\n");
return -1;
--
2.17.1
next prev parent reply other threads:[~2021-10-20 2:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 2:49 [PATCH next v7 00/12] aspeed: Support secure boot chain with FIT image verification Chia-Wei Wang
2021-10-20 2:49 ` Chia-Wei Wang [this message]
2021-10-21 0:08 ` [PATCH next v7 01/12] image: fit: Fix parameter name for hash algorithm Joel Stanley
2021-10-21 2:23 ` ChiaWei Wang
2021-10-24 19:53 ` Simon Glass
2021-10-20 2:49 ` [PATCH next v7 02/12] aspeed: ast2600: Enlarge SRAM size Chia-Wei Wang
2021-10-21 0:08 ` Joel Stanley
2021-10-20 2:49 ` [PATCH next v7 03/12] clk: ast2600: Add YCLK control for HACE Chia-Wei Wang
2021-10-20 2:49 ` [PATCH next v7 04/12] crypto: aspeed: Add AST2600 HACE support Chia-Wei Wang
2021-10-21 0:08 ` Joel Stanley
2021-10-21 2:12 ` ChiaWei Wang
2021-11-16 6:32 ` Joel Stanley
2021-11-17 8:41 ` Johnny Huang
2021-10-21 1:33 ` Dhananjay Phadke
2021-10-21 1:57 ` ChiaWei Wang
2021-10-25 2:40 ` ChiaWei Wang
2021-10-20 2:49 ` [PATCH next v7 05/12] ARM: dts: ast2600: Add HACE to device tree Chia-Wei Wang
2021-10-20 2:49 ` [PATCH next v7 06/12] clk: ast2600: Add RSACLK control for ACRY Chia-Wei Wang
2021-10-21 0:08 ` Joel Stanley
2021-10-25 2:05 ` ChiaWei Wang
2021-10-20 2:49 ` [PATCH next v7 07/12] crypto: aspeed: Add AST2600 ACRY support Chia-Wei Wang
2021-10-21 0:24 ` Joel Stanley
2021-10-21 2:02 ` ChiaWei Wang
2021-10-20 2:49 ` [PATCH next v7 08/12] ARM: dts: ast2600: Add ACRY to device tree Chia-Wei Wang
2021-10-21 0:25 ` Joel Stanley
2021-10-20 2:49 ` [PATCH next v7 09/12] ast2600: spl: Locate load buffer in DRAM space Chia-Wei Wang
2021-10-21 0:26 ` Joel Stanley
2021-10-20 2:49 ` [PATCH next v7 10/12] configs: ast2600-evb: Enable SPL FIT support Chia-Wei Wang
2021-10-21 0:27 ` Joel Stanley
2021-10-20 2:49 ` [PATCH next v7 11/12] configs: aspeed: Make EXTRA_ENV_SETTINGS board specific Chia-Wei Wang
2021-10-21 0:31 ` Joel Stanley
2021-10-21 2:00 ` ChiaWei Wang
2021-10-20 2:49 ` [PATCH next v7 12/12] configs: ast2600: Boot kernel FIT in DRAM Chia-Wei Wang
2021-10-25 2:43 ` [PATCH next v7 00/12] aspeed: Support secure boot chain with FIT image verification ChiaWei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020024933.16964-2-chiawei_wang@aspeedtech.com \
--to=chiawei_wang@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=johnny_huang@aspeedtech.com \
--cc=lukma@denx.de \
--cc=mr.nuke.me@gmail.com \
--cc=ryan_chen@aspeedtech.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox