Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

Simon Glass
2021-10-24T20:00:23Z

Hi Andy,

On Wed, 20 Oct 2021 at 06:37, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The dsdt.asl is usually combined out of several files that are included
> in the main one. Whenever we change the content of any of such files,
> build system is not able to recognize them. Hence the easiest way is to
> force DSDT rebuild each time we run make.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> scripts/Makefile.lib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Ick. Since it uses #include, doesn't the dependency generation work with this?

>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 07696e86bb54..8c3c893b398a 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -441,7 +441,7 @@ cmd_acpi_c_asl= \
> iasl -p $@ -tc $(ASL_TMP) $(if $(KBUILD_VERBOSE:1=), >/dev/null) && \
> mv $(patsubst %.c,%.hex,$@) $@
>
> -$(obj)/dsdt.c: $(src)/dsdt.asl
> +$(obj)/dsdt.c: $(src)/dsdt.asl FORCE
> $(call cmd,acpi_c_asl)
> $(Q)sed -i -e "s,dsdt_aml_code,AmlCode," $@
>
> --
> 2.33.0
>

Regards,
Simon