Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

Heinrich Schuchardt
2023-12-09T14:40:28Z

On 11/30/23 03:45, Simon Glass wrote:
> Hi,
>
> On Wed, 29 Nov 2023 at 10:17, Heinrich Schuchardt
> <heinrich.schuchardt@canonical.com> wrote:
>>
>> On 20.10.21 14:37, Andy Shevchenko wrote:
>>> The dsdt.asl is usually combined out of several files that are included
>>> in the main one. Whenever we change the content of any of such files,
>>> build system is not able to recognize them. Hence the easiest way is to
>>> force DSDT rebuild each time we run make.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> The build process that you describe is not in our documentation.
>>
>> By which defconfig is $(src)/dsdt.asl consumed? Where does it come from?
>> Please, provide a reproducible example.
>>
>> Would you be able to provide a documentation patch explaining how to use
>> a user provided dsdt.asl file?
>>
>> Best regards
>>
>> Heinrich
>>
>>
>>> ---
>>> scripts/Makefile.lib | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>>> index 07696e86bb54..8c3c893b398a 100644
>>> --- a/scripts/Makefile.lib
>>> +++ b/scripts/Makefile.lib
>>> @@ -441,7 +441,7 @@ cmd_acpi_c_asl= \
>>> iasl -p $@ -tc $(ASL_TMP) $(if $(KBUILD_VERBOSE:1=), >/dev/null) && \
>>> mv $(patsubst %.c,%.hex,$@) $@
>>>
>>> -$(obj)/dsdt.c: $(src)/dsdt.asl
>>> +$(obj)/dsdt.c: $(src)/dsdt.asl FORCE
>>> $(call cmd,acpi_c_asl)
>>> $(Q)sed -i -e "s,dsdt_aml_code,AmlCode," $@
>>>
>>
>
> I agree that this patch is better than having the bug. But yes the
> docs could really use some notes here, for the person who does come
> along and clean up the dependency bug.
>
> Regards,
> Simon

The patch is neither applicable to origin/next nor to origin/master.

I only find a line

$(obj)/dsdt_generated.c: $(src)/dsdt.asl

Best regards

Heinrich