Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

Andy Shevchenko
2023-11-29T12:52:35Z

On Wed, Mar 30, 2022 at 12:21:25PM +0300, Andy Shevchenko wrote:
> On Mon, Oct 25, 2021 at 09:52:45PM +0300, Andy Shevchenko wrote:
> > On Mon, Oct 25, 2021 at 09:18:56AM -0600, Simon Glass wrote:
> > > On Mon, 25 Oct 2021 at 01:34, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > > On Sun, Oct 24, 2021 at 11:00 PM Simon Glass <sjg@chromium.org> wrote:
> > > > > On Wed, 20 Oct 2021 at 06:37, Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > >
> > > > > > The dsdt.asl is usually combined out of several files that are included
> > > > > > in the main one. Whenever we change the content of any of such files,
> > > > > > build system is not able to recognize them. Hence the easiest way is to
> > > > > > force DSDT rebuild each time we run make.
> > > >
> > > > > Ick. Since it uses #include, doesn't the dependency generation work with this?
> > > >
> > > > How?
> > >
> > > If you do a sandbox build you will see this file:
> > >
> > > arch/sandbox/dts/.sandbox.dtb.cmd
> > >
> > > It contains the dependencies used to compile the device tree. Can we
> > > use the same mechanism? There is a .cmd file for the dsdt file but it
> > > does not seem to have the correct contents.
> >
> > A spent more than couple of hours to fight with `make` and failed.
> > Maybe you can improve the below (it still rebuilds always)
>
> So, can we fix this annoying bug, please?

Any news here? If no other solution, please apply this patch.

--
With Best Regards,
Andy Shevchenko