From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A64A8C433F5 for ; Wed, 20 Oct 2021 13:29:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFD236128E for ; Wed, 20 Oct 2021 13:29:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CFD236128E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5B93282F9E; Wed, 20 Oct 2021 15:29:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E564F83259; Wed, 20 Oct 2021 15:29:11 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id E86A68018E for ; Wed, 20 Oct 2021 15:29:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 891551FB; Wed, 20 Oct 2021 06:29:06 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 518293F73D; Wed, 20 Oct 2021 06:29:05 -0700 (PDT) Date: Wed, 20 Oct 2021 14:29:02 +0100 From: Andre Przywara To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Samuel Holland , u-boot@lists.denx.de, Jagan Teki , "Alex G ." , Artem Lapkin , Priyanka Jain , Sughosh Ganu , Marek =?UTF-8?B?QmVow7pu?= Subject: Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL Message-ID: <20211020142902.12219c45@donnerap.cambridge.arm.com> In-Reply-To: <20211020072925.drf6622qhq4yykg6@pali> References: <20211020024455.48136-1-samuel@sholland.org> <20211020024455.48136-2-samuel@sholland.org> <20211020072925.drf6622qhq4yykg6@pali> Organization: ARM X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 20 Oct 2021 09:29:25 +0200 Pali Roh=C3=A1r wrote: Hi, > On Tuesday 19 October 2021 21:44:51 Samuel Holland wrote: > > Some image types (kwbimage and mxsimage) always depend on OpenSSL, so > > they can only be included in mkimage when TOOLS_LIBCRYPTO is selected. > > Use Makefile logic to conditionally link the files. > >=20 > > Signed-off-by: Samuel Holland =20 >=20 > NAK. >=20 > As explained in previous email [1], kwbimage is required for building > Kirkwood, Dove, A370, AXP, A375, A38x, A39x and MSYS platforms. > Therefore it cannot be disabled or hidden behind some user config > options for these platforms (and it does not matter if it is crypto > option or any other option). So somehow we need to find a solution between your view and Alex' view of things. First: Pali, do you see any actual problem at the moment? TOOLS_LIBCRYPTO defaults to y, so if I am not mistaken that means that a user would need to deliberately turn that off to trigger build errors? And also: the situation with this patch is not worse as before, isn't it? So if it's just the missing improvement that you are concerned about, I am not sure that should block this patch? I mean you could always propose your own version of that missing piece, to improve the situation for the boards you care about? And we should have this discussion there? As it stands right now, this patch just improves things (just not *everything*), and it is a prerequisite for the rest of the series (unrelated to your problems), so I would like to go ahead on this one. Cheers, Andre. > kwbimage must be unconditionally enabled on > these platforms like it was before this change, as it is crucial part of > build. >=20 > [1] - https://lore.kernel.org/u-boot/20211015114735.rig3e4cuc7mn6a7e@pali/ >=20 > > --- > >=20 > > Changes in v4: > > - Do not select TOOLS_LIBCRYPTO anywhere > >=20 > > Changes in v3: > > - Selected TOOLS_LIBCRYPTO on all platforms that use kwbimage (as best > > as I can tell, using the suggestions from Pali Roh=C3=A1r) > >=20 > > Changes in v2: > > - Refactored the first patch on top of TOOLS_LIBCRYPTO > >=20 > > scripts/config_whitelist.txt | 1 - > > tools/Makefile | 19 +++++-------------- > > tools/mxsimage.c | 3 --- > > 3 files changed, 5 insertions(+), 18 deletions(-) > >=20 > > diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt > > index cd94b5777a..affae6875d 100644 > > --- a/scripts/config_whitelist.txt > > +++ b/scripts/config_whitelist.txt > > @@ -828,7 +828,6 @@ CONFIG_MXC_UART_BASE > > CONFIG_MXC_USB_FLAGS > > CONFIG_MXC_USB_PORT > > CONFIG_MXC_USB_PORTSC > > -CONFIG_MXS > > CONFIG_MXS_AUART > > CONFIG_MXS_AUART_BASE > > CONFIG_MXS_OCOTP > > diff --git a/tools/Makefile b/tools/Makefile > > index 999fd46531..a9b3d982d8 100644 > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -94,9 +94,11 @@ ECDSA_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) :=3D $(addprefi= x lib/ecdsa/, ecdsa-libcrypto. > > AES_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) :=3D $(addprefix lib/aes/, \ > > aes-encrypt.o aes-decrypt.o) > > =20 > > -# Cryptographic helpers that depend on openssl/libcrypto > > -LIBCRYPTO_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) :=3D $(addprefix lib/, \ > > - fdt-libcrypto.o) > > +# Cryptographic helpers and image types that depend on openssl/libcryp= to > > +LIBCRYPTO_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) :=3D \ > > + lib/fdt-libcrypto.o \ > > + kwbimage.o \ > > + mxsimage.o > > =20 > > ROCKCHIP_OBS =3D lib/rc4.o rkcommon.o rkimage.o rksd.o rkspi.o > > =20 > > @@ -118,10 +120,8 @@ dumpimage-mkimage-objs :=3D aisimage.o \ > > imximage.o \ > > imx8image.o \ > > imx8mimage.o \ > > - kwbimage.o \ > > lib/md5.o \ > > lpc32xximage.o \ > > - mxsimage.o \ > > omapimage.o \ > > os_support.o \ > > pblimage.o \ > > @@ -156,22 +156,13 @@ fit_info-objs :=3D $(dumpimage-mkimage-objs) fi= t_info.o > > fit_check_sign-objs :=3D $(dumpimage-mkimage-objs) fit_check_sign.o > > file2include-objs :=3D file2include.o > > =20 > > -ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_TOOLS_LIBCRYPTO),) > > -# Add CONFIG_MXS into host CFLAGS, so we can check whether or not regi= ster > > -# the mxsimage support within tools/mxsimage.c . > > -HOSTCFLAGS_mxsimage.o +=3D -DCONFIG_MXS > > -endif > > - > > ifdef CONFIG_TOOLS_LIBCRYPTO > > # This affects include/image.h, but including the board config file > > # is tricky, so manually define this options here. > > HOST_EXTRACFLAGS +=3D -DCONFIG_FIT_SIGNATURE > > HOST_EXTRACFLAGS +=3D -DCONFIG_FIT_SIGNATURE_MAX_SIZE=3D0xffffffff > > HOST_EXTRACFLAGS +=3D -DCONFIG_FIT_CIPHER > > -endif > > =20 > > -# MXSImage needs LibSSL > > -ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_ARMADA_38X)$(CONFIG_TOOLS_= LIBCRYPTO),) > > HOSTCFLAGS_kwbimage.o +=3D \ > > $(shell pkg-config --cflags libssl libcrypto 2> /dev/null || echo "") > > HOSTLDLIBS_mkimage +=3D \ > > diff --git a/tools/mxsimage.c b/tools/mxsimage.c > > index 002f4b525a..2bfbb421eb 100644 > > --- a/tools/mxsimage.c > > +++ b/tools/mxsimage.c > > @@ -5,8 +5,6 @@ > > * Copyright (C) 2012-2013 Marek Vasut > > */ > > =20 > > -#ifdef CONFIG_MXS > > - > > #include > > #include > > #include > > @@ -2363,4 +2361,3 @@ U_BOOT_IMAGE_TYPE( > > NULL, > > mxsimage_generate > > ); > > -#endif > > --=20 > > 2.32.0 > > =20