Re: [PATCH] x86: Fix i8254 ifdef include guard

Bin Meng
2021-10-27T03:28:39Z

On Wed, Oct 27, 2021 at 11:08 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva <adelva@google.com> wrote:
> >
> > When building U-Boot with clang, it notices that the i8254.h include
> > guard does not work correctly due to a typo. Fix it.
> >
> > Signed-off-by: Alistair Delva <adelva@google.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Bin Meng <bmeng.cn@gmail.com>
> > ---
> > arch/x86/include/asm/i8254.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/i8254.h b/arch/x86/include/asm/i8254.h
> > index d769daf85d..bb8930338b 100644
> > --- a/arch/x86/include/asm/i8254.h
> > +++ b/arch/x86/include/asm/i8254.h
> > @@ -7,7 +7,7 @@
> > /* i8254.h Intel 8254 PIT registers */
> >
> > #ifndef _ASMI386_I8254_H_
> > -#define _ASMI386_I8954_H_
> > +#define _ASMI386_I8254_H_
>
> There is another I8954 at the end of this file. I can fix it when applying.
>
> >
> > #define PIT_T0 0x00 /* PIT channel 0 count/status */
> > #define PIT_T1 0x01 /* PIT channel 1 count/status */
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!