Re: [PATCH] efi_loader: Fix link of EFI apps with ld.lld

Heinrich Schuchardt
2021-10-20T22:05:50Z

On 10/20/21 11:31 PM, Alistair Delva wrote:
> When compiling U-Boot with ld.lld as the linker, the helloworld EFI app
> example fails to link:
>
> LD lib/efi_loader/helloworld_efi.so
> ld.lld: error: section: .dynamic is not contiguous with other relro
> sections
>
> LLD will always create RELRO program header regardless of target
> emulation, whereas BFD may automatically disable it for unsupported
> targets. Add -znorelro to disable it explicitly in all cases.
>
> Signed-off-by: Alistair Delva <adelva@google.com>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Nick Desaulniers <ndesaulniers@google.com>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
> scripts/Makefile.lib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 07696e86bb..39f03398ed 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -403,7 +403,7 @@ $(obj)/%.efi: $(obj)/%_efi.so
>
> quiet_cmd_efi_ld = LD $@
> cmd_efi_ld = $(LD) -nostdlib -znocombreloc -T $(EFI_LDS_PATH) -shared \
> - -Bsymbolic -s $^ -o $@
> + -Bsymbolic -znorelro -s $^ -o $@
>
> EFI_LDS_PATH = $(srctree)/arch/$(ARCH)/lib/$(EFI_LDS)
>
>