From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB1AC433F5 for ; Thu, 21 Oct 2021 12:34:04 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0127B611CE for ; Thu, 21 Oct 2021 12:34:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0127B611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D6AC983374; Thu, 21 Oct 2021 14:34:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="e4MaS3aA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 50A3583409; Thu, 21 Oct 2021 14:33:59 +0200 (CEST) Received: from mail.nic.cz (lists.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 43BC680C72 for ; Thu, 21 Oct 2021 14:33:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPSA id C3AD0140928; Thu, 21 Oct 2021 14:33:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1634819635; bh=SIOP6leCY8c4f0xCrB9PQlOX68K9COZmqP3UYNAPs/M=; h=Date:From:To; b=e4MaS3aAYi1z71Hg+wVaa8OWQK3VVpxhKJI9ciwafjYv1hqueVPBm/6AtJhmrwzvC gn4FPq7suMzSMTJRVoYsroVa3z600R2puKvSTuLUwOnQbEbpoGdXoCYcLmuPqz5mup Hk+glAJtrjflfHrfrg8CUEvEAC/AkbuLnPG8+H8o= Date: Thu, 21 Oct 2021 14:33:55 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Samuel Holland Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Andre Przywara , u-boot@lists.denx.de, Jagan Teki , "Alex G ." , Artem Lapkin , Priyanka Jain , Sughosh Ganu Subject: Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL Message-ID: <20211021143355.6d979a0c@thinkpad> In-Reply-To: References: <20211020024455.48136-1-samuel@sholland.org> <20211020024455.48136-2-samuel@sholland.org> <20211020072925.drf6622qhq4yykg6@pali> <20211020142902.12219c45@donnerap.cambridge.arm.com> <20211020134752.62k4fxukucj5rodh@pali> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Samuel, On Wed, 20 Oct 2021 09:14:11 -0500 Samuel Holland wrote: > Andre is correct. No version of this patch makes *any* change to *any* > in-tree defconfig build, because TOOLS_LIBCRYPTO=y in all defconfigs. > Even if I was to accept your assertion that it hides a possible error on > platforms using kwbimage: > > 1) It does not *create* any errors for those platforms, and > 2) It *fixes* possible errors for almost all other platforms. It does create possible errors, since it is possible to choose config options which won't compile. The fact that defconfig have this option enabled for those platforms does not matter. What matters is that I can then validly change the config with make menuconfig, and it won't compile. A compilation error should not occur with valid config options. That's why dependencies need to be made in Kconfig, so that if Kconfig decides that kwbimage is to be built, then it will force crypto. (Yes, I know that there currently are many ways to change Kconfig options and the result will fail to compile. That behaviour is unwanted and should be fixed by adding Kconfig dependencies so that it isn't possible to choose configuration that won't compile.) Marek