Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

Marek Behún
2021-10-21T12:34:04Z

Hi Samuel,

On Wed, 20 Oct 2021 09:14:11 -0500
Samuel Holland <samuel@sholland.org> wrote:

> Andre is correct. No version of this patch makes *any* change to *any*
> in-tree defconfig build, because TOOLS_LIBCRYPTO=y in all defconfigs.

> Even if I was to accept your assertion that it hides a possible error on
> platforms using kwbimage:
>
> 1) It does not *create* any errors for those platforms, and
> 2) It *fixes* possible errors for almost all other platforms.

It does create possible errors, since it is possible to choose config
options which won't compile.

The fact that defconfig have this option enabled for those platforms
does not matter. What matters is that I can then validly change the
config with make menuconfig, and it won't compile. A compilation error
should not occur with valid config options. That's why dependencies
need to be made in Kconfig, so that if Kconfig decides that kwbimage is
to be built, then it will force crypto.

(Yes, I know that there currently are many ways to change Kconfig
options and the result will fail to compile. That behaviour is
unwanted and should be fixed by adding Kconfig dependencies so that it
isn't possible to choose configuration that won't compile.)

Marek