From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A037EC433F5 for ; Thu, 21 Oct 2021 13:28:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEAEF610CB for ; Thu, 21 Oct 2021 13:28:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EEAEF610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 88F6480234; Thu, 21 Oct 2021 15:28:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="Sd/8L1jJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A61FE83473; Thu, 21 Oct 2021 15:28:35 +0200 (CEST) Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5D264831D3 for ; Thu, 21 Oct 2021 15:28:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPSA id B77E2140BF1; Thu, 21 Oct 2021 15:28:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1634822911; bh=2G97pj77zGxXAjQmWlgfoCxGF9NL7pHZM/Ie42UTgTw=; h=Date:From:To; b=Sd/8L1jJZLNxcwBpGKInpCxo9pLrjY+mMfnnNlsfIl5gRMvGuuvnMYIUJqW9xqrzb EoZ4O5XtksXo6OQscY4oDhDgkDm1ZievUOJPBsfiCjphlJVQ+2MFHfi9P5XKxypkQ3 Fz1Y7K4+Q/83oir4qeg3Sipuy9E+CLQniSBj/rb0= Date: Thu, 21 Oct 2021 15:28:31 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Wolfgang Denk , Simon Glass Cc: Tom Rini , U-Boot Mailing List , Rasmus Villemoes , Heinrich Schuchardt , Joe Hershberger Subject: Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file Message-ID: <20211021152831.15524883@thinkpad> In-Reply-To: <20211021152537.441c37b9@thinkpad> References: <20211019224422.1447059-1-sjg@chromium.org> <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3682215.1634809802@gemini.denx.de> <20211021122325.GX7964@bill-the-cat> <3695947.1634821611@gemini.denx.de> <20211021152537.441c37b9@thinkpad> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 21 Oct 2021 15:25:37 +0200 Marek Beh=C3=BAn wrote: > Hello, >=20 > On Thu, 21 Oct 2021 15:06:51 +0200 > Wolfgang Denk wrote: >=20 > > I confirm that '+=3D' looks better. But '+=3D" is technically broken. = =20 >=20 > a bit of my opinion: > I think =3D+ will confuse far more people than + as last character of var > name working weirdly. But I also think that + should be supported as > last character. Therefore I propose backslash escaping in variable name, > i.e. > var+=3Dvalue > appends value to var, while > var\+=3Dvalue > sets variable with name "var+" >=20 > Marek Also, I think that it would be better if spaces and tabs were allowed to indent the .env file, i.e. var_a =3D 3 var_bcd =3D 7 should set "var_a" to "3", "var_bcd" to "7". If special character are needed in either name or value, they could be escaped and/or quoted. Marek